From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmkVI-0002I3-GC for qemu-devel@nongnu.org; Wed, 12 Jun 2013 08:50:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UmkVH-0008AL-3q for qemu-devel@nongnu.org; Wed, 12 Jun 2013 08:50:20 -0400 Sender: Paolo Bonzini Message-ID: <51B86E88.2020405@redhat.com> Date: Wed, 12 Jun 2013 08:50:16 -0400 From: Paolo Bonzini MIME-Version: 1.0 References: <1371040588-17938-1-git-send-email-mjt@msgid.tls.msk.ru> In-Reply-To: <1371040588-17938-1-git-send-email-mjt@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH trivial] main-loop: do not include slirp/slirp.h, use libslirp.h instead List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Il 12/06/2013 08:36, Michael Tokarev ha scritto: > > Including slirp/slirp.h is somewhat dangerous since it redefines > errno on WIN32, so any file including it may misbehave wrt errno. > > Unfortunately libslirp isn't self-contained, it needs declaration > of struct in_addr, which is provided by qemu/sockets.h. Maybe > instead of #including qemu/sockets.h before libslirp.h, it is > better to make the latter self-contained. Yeah, but I agree with having the smallest patch for now. Reviewed-by: Paolo Bonzini