From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmkzS-0003uD-2t for qemu-devel@nongnu.org; Wed, 12 Jun 2013 09:21:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UmkzN-0002HA-7I for qemu-devel@nongnu.org; Wed, 12 Jun 2013 09:21:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmkzM-0002Gy-Vp for qemu-devel@nongnu.org; Wed, 12 Jun 2013 09:21:25 -0400 Message-ID: <51B875D0.9070202@redhat.com> Date: Wed, 12 Jun 2013 15:21:20 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1371037877-14821-1-git-send-email-kraxel@redhat.com> <20130612081815.6fbd86c1@redhat.com> In-Reply-To: <20130612081815.6fbd86c1@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] console: extend screendump monitor cmd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: "Anthony Liguori (maintainer:Graphics)" , qemu-devel@nongnu.org, "Markus Armbruster (supporter:QAPI Schema)" Hi, >> -{ 'command': 'screendump', 'data': {'filename': 'str'} } >> +{ 'command': 'screendump', 'data': {'filename': 'str', >> + '*device' : 'str'} } > > We can't add new optional parameters to QMP commands because it's > currently impossible for mngt apps to discover them. > > We have two options: 1. add this as a new command or 2. wait for > full schema introspection (which we might get for 1.6). "might get" sounds like it isn't a save bet, so I guess I better should go for option (1) ... cheers, Gerd