From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49028)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UmlWS-0000uF-3R
	for qemu-devel@nongnu.org; Wed, 12 Jun 2013 09:55:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UmlWQ-000895-Kq
	for qemu-devel@nongnu.org; Wed, 12 Jun 2013 09:55:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58229)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UmlWQ-00088s-CP
	for qemu-devel@nongnu.org; Wed, 12 Jun 2013 09:55:34 -0400
Message-ID: <51B87DCA.1060309@redhat.com>
Date: Wed, 12 Jun 2013 09:55:22 -0400
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1370529574-31069-1-git-send-email-hdegoede@redhat.com>
	<1370529574-31069-2-git-send-email-hdegoede@redhat.com>
	<CAEgOgz6bAiXEmv1X-6WtQEGn5REa-vt0MPeLY9BtnZ3NRNkaog@mail.gmail.com>
In-Reply-To: <CAEgOgz6bAiXEmv1X-6WtQEGn5REa-vt0MPeLY9BtnZ3NRNkaog@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] device_tree: Fix build with latest
	libfdt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Hans de Goede <hdegoede@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, David Gibson <david@gibson.dropbear.id.au>

Il 10/06/2013 22:13, Peter Crosthwaite ha scritto:
> Hi Hans,
> 
> On Fri, Jun 7, 2013 at 12:39 AM, Hans de Goede <hdegoede@redhat.com> wrote:
>> We override libfdt_env.h with our own copy, and the latest libfdt expects
>> libfdt_env.h to define fdt##_t types.
>>
> 
> This discussion is open on list, and AFAICT the consensus is to drop
> qemus libfdt_env.h altogether. QEMU should not be trying to override
> libfdt_env.h because it does not have a good reason to.
> 
> [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h
> 
> CCing the crowd.

F19, F20 and EPEL6 will all distribute libfdt_env.h by the time 1.6 is
out.  If this patch is not qemu-stable material, you have my ack too.
Thanks!

Paolo