[Qemu-devel] [PATCH trivial] gitignore: unignore *.patch

[Qemu-devel] [PATCH trivial] gitignore: unignore *.patch

[Michael Tokarev]

This partially reverts:

 commit 082369e62c5bbaba89f173c2b803bc24115bb111
 Author: liguang <lig.fnst@cn.fujitsu.com>
 Date:   Fri Mar 22 16:44:13 2013 +0800

    gitignore: ignore more files

I'm not sure how this went in.  The thing is that
ignoring *.patch, in my opinion, is just wrong.
Especially for downstreams who apply patches for
real.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 .gitignore |    1 -
 1 file changed, 1 deletion(-)

diff --git a/.gitignore b/.gitignore
index 64e9466..0fe114d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -82,7 +82,6 @@ fsdev/virtfs-proxy-helper.pod
 *.swp
 *.orig
 .pc
-*.patch
 *.gcda
 *.gcno
 patches
-- 
1.7.10.4

Re: [Qemu-devel] [PATCH trivial] gitignore: unignore *.patch

[Peter Maydell]

On 5 June 2013 22:16, Michael Tokarev <mjt@tls.msk.ru> wrote:
> This partially reverts:
>
>  commit 082369e62c5bbaba89f173c2b803bc24115bb111
>  Author: liguang <lig.fnst@cn.fujitsu.com>
>  Date:   Fri Mar 22 16:44:13 2013 +0800
>
>     gitignore: ignore more files
>
> I'm not sure how this went in.  The thing is that
> ignoring *.patch, in my opinion, is just wrong.
> Especially for downstreams who apply patches for
> real.

Personally I think a lot of the random rubbish in
our .gitignore is bogus and should be removed.
Basically anything that's an editor dropping or
.patch or TAGS file or similar is a local workflow
thing and should be dealt with by setting up a global
ignorefile in your local git config. The only
things in the .gitignore in the public repo should
be files which QEMU's build process itself creates.

But I know not everybody agrees with this, which is
why all this stuff is in the .gitignore :-)

thanks
-- PMM

Re: [Qemu-devel] [PATCH trivial] gitignore: unignore *.patch

[li guang]

在 2013-06-06四的 01:16 +0400，Michael Tokarev写道：
> This partially reverts:
> 
>  commit 082369e62c5bbaba89f173c2b803bc24115bb111
>  Author: liguang <lig.fnst@cn.fujitsu.com>
>  Date:   Fri Mar 22 16:44:13 2013 +0800
> 
>     gitignore: ignore more files
> 
> I'm not sure how this went in.  The thing is that
> ignoring *.patch, in my opinion, is just wrong.
> Especially for downstreams who apply patches for
> real.
> 

ignore *.patch is convenient in my opinion, you can change
if it bothered someone else.

thanks!

> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  .gitignore |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/.gitignore b/.gitignore
> index 64e9466..0fe114d 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -82,7 +82,6 @@ fsdev/virtfs-proxy-helper.pod
>  *.swp
>  *.orig
>  .pc
> -*.patch
>  *.gcda
>  *.gcno
>  patches

Re: [Qemu-devel] [PATCH trivial] gitignore: unignore *.patch

[Michael Tokarev]

06.06.2013 01:22, Peter Maydell wrote:
> Personally I think a lot of the random rubbish in
> our .gitignore is bogus and should be removed.
> Basically anything that's an editor dropping or
> .patch or TAGS file or similar is a local workflow
> thing and should be dealt with by setting up a global
> ignorefile in your local git config. The only
> things in the .gitignore in the public repo should
> be files which QEMU's build process itself creates.
> 
> But I know not everybody agrees with this, which is
> why all this stuff is in the .gitignore :-)

I'm one of the few who completely agrees, there's no
place for various random rubbery in there, only things
which are really generated during build should be there.

I'd really love to remove all the cruft.  But who else
disagrees?

Thanks,

/mjt

Re: [Qemu-devel] [PATCH trivial] gitignore: unignore *.patch

[Laszlo Ersek]

On 06/12/13 13:51, Michael Tokarev wrote:
> 06.06.2013 01:22, Peter Maydell wrote:
>> Personally I think a lot of the random rubbish in
>> our .gitignore is bogus and should be removed.
>> Basically anything that's an editor dropping or
>> .patch or TAGS file or similar is a local workflow
>> thing and should be dealt with by setting up a global
>> ignorefile in your local git config. The only
>> things in the .gitignore in the public repo should
>> be files which QEMU's build process itself creates.
>>
>> But I know not everybody agrees with this, which is
>> why all this stuff is in the .gitignore :-)
> 
> I'm one of the few who completely agrees, there's no
> place for various random rubbery in there, only things
> which are really generated during build should be there.
> 
> I'd really love to remove all the cruft.  But who else
> disagrees?

I agree that .gitignore should list only files produced by the build
process. Anything else can be added to a global ignore file (which I
haven't heard of before, but it probably does exist :)), *or* to

  .git/info/exclude

(recommended by Eric Blake to me some months back)

This file is not tracked like .gitignore, but it doesn't need tracking.

Laszlo