From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Umupz-00041d-Jp for qemu-devel@nongnu.org; Wed, 12 Jun 2013 19:52:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Umupy-0004dn-EJ for qemu-devel@nongnu.org; Wed, 12 Jun 2013 19:52:23 -0400 Received: from speedy.comstyle.com ([2001:470:1d:8c::2]:38901 helo=mail.comstyle.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Umupy-0004bK-8k for qemu-devel@nongnu.org; Wed, 12 Jun 2013 19:52:22 -0400 Message-ID: <51B90909.2010805@comstyle.com> Date: Wed, 12 Jun 2013 19:49:29 -0400 From: Brad Smith MIME-Version: 1.0 References: <1370445949-6666-1-git-send-email-mjt@msgid.tls.msk.ru> <51B71EA9.1020307@msgid.tls.msk.ru> In-Reply-To: <51B71EA9.1020307@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] create qemu_openpty_raw() helper function and move it to a separate file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Paolo Bonzini , Anthony Liguori , qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= On 11/06/13 8:57 AM, Michael Tokarev wrote: > 05.06.2013 19:25, Michael Tokarev wrote: >> In two places qemu uses openpty() which is very system-dependent, >> and in both places the pty is switched to raw mode as well. >> Make a wrapper function which does both steps, and move all the >> system-dependent complexity into a separate file, together >> with static/local implementations of openpty() and cfmakeraw() >> from qemu-char.c. >> >> It is in a separate file, not part of oslib-posix.c, because >> openpty() often resides in -lutil which is not linked to >> every program qemu builds. >> >> This change removes #including of , >> and other rather specific system headers out of qemu-common.h, >> which isn't a place for such specific headers really. > > So guys/gals what do you think of this? It builds on OpenBSD > and FreeBSD as verified by Brad Smith and me, and it builds on > Linux. And it is trivial enough for qemu-trivial (no actual > code changes, just some refactoring and moving). Can we > let it in? > > There's no one else who signed this off ;) > >> Signed-off-by: Michael Tokarev It would be nice to get this in to fix the build with Solaris (that's if there is nothing else I am not aware of which breaks the build there) and to get this in the queue for 1.5 too. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.