From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Un3FL-0001MX-4v for qemu-devel@nongnu.org; Thu, 13 Jun 2013 04:51:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Un3FH-0006jI-9m for qemu-devel@nongnu.org; Thu, 13 Jun 2013 04:51:07 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:50069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Un3FH-0006i4-01 for qemu-devel@nongnu.org; Thu, 13 Jun 2013 04:51:03 -0400 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 13 Jun 2013 09:48:44 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id DB0342190023 for ; Thu, 13 Jun 2013 09:54:19 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5D8olDw24182984 for ; Thu, 13 Jun 2013 08:50:47 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r5D8ovBt025740 for ; Thu, 13 Jun 2013 02:50:57 -0600 Message-ID: <51B987F0.60809@de.ibm.com> Date: Thu, 13 Jun 2013 10:50:56 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1370626087-840-1-git-send-email-jjherne@us.ibm.com> In-Reply-To: <1370626087-840-1-git-send-email-jjherne@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/8] [PATCH RFC v2] s390-qemu: cpu hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Jason J. Herne" , =?ISO-8859-1?Q?Andreas_F=E4r?= =?ISO-8859-1?Q?ber?= Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, Viktor Mihajlovski , jfrei@linux.vnet.ibm.com, imammedo@redhat.com On 07/06/13 19:27, Jason J. Herne wrote: > Latest code for cpu Hotplug designed to be controled via the QOM infrastructure. > cpu on S390 are treated as devices via a new platform independent > infrastructure I designed to allow this "new way" to exist with the "old way" > of representing cpus. > > The Qemu command line now allows "-device s390-cpu" which will instantiate a > cpu device. This is additive to anything that might be specified on the -smp > parameter. > > Devices can be hot plugged via the monitor command "device_add s390-cpu". > Hotplugged cpus are created in the configured state and can be used by the > guest after the guest onlines the cpu by: > "echo 1 > /sys/bus/cpu/devices/cpuN/online" > > Hot unplugging is currently not implemented by this code. Adding Viktor, Andreas. Andreas, since we are the first ones going forward with cpu is a device (on a command level) we still have to provide the old cpu_add and query commands to make libvirt work regarding cpu hotplugging. Are you ok with having the x86 commands as wrappers around the new ones? Christian