From: "Andreas Färber" <afaerber@suse.de>
To: Mans Rullgard <mans@mansr.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] target-arm: explicitly decode SEVL instruction
Date: Thu, 13 Jun 2013 15:15:29 +0200 [thread overview]
Message-ID: <51B9C5F1.2020503@suse.de> (raw)
In-Reply-To: <1370606786-5650-3-git-send-email-mans@mansr.com>
Am 07.06.2013 14:06, schrieb Mans Rullgard:
> The ARMv8 SEVL instruction is in the architectural hint space already
> emulated as nop. This makes the decoding of SEVL explicit for clarity.
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> target-arm/translate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index f529257..cfd148e 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -3501,6 +3501,7 @@ static void gen_nop_hint(DisasContext *s, int val)
> break;
> case 2: /* wfe */
> case 4: /* sev */
> + case 5: /* sevl */
> /* TODO: Implement SEV and WFE. May help SMP performance. */
> default: /* nop */
> break;
So does SEVL need to be implemented? Then the TODO should be updated.
Otherwise moving it a line down may be clearer.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-06-13 13:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 12:06 [Qemu-devel] [PATCH 1/3] target-arm: add feature flag for ARMv8 Mans Rullgard
2013-06-07 12:06 ` [Qemu-devel] [PATCH 2/3] target-arm: implement LDA/STL instructions Mans Rullgard
2013-06-13 14:01 ` Peter Maydell
2013-06-17 16:50 ` [Qemu-devel] [PATCH v2] " Mans Rullgard
2013-06-20 17:51 ` Peter Maydell
2013-07-01 13:46 ` [Qemu-devel] [PATCH v3] " Mans Rullgard
2013-07-02 12:46 ` Peter Maydell
2013-06-07 12:06 ` [Qemu-devel] [PATCH 3/3] target-arm: explicitly decode SEVL instruction Mans Rullgard
2013-06-13 12:59 ` Peter Maydell
2013-06-13 13:15 ` Andreas Färber [this message]
2013-06-13 13:39 ` Måns Rullgård
2013-07-02 12:53 ` Peter Maydell
2013-06-13 12:54 ` [Qemu-devel] [PATCH 1/3] target-arm: add feature flag for ARMv8 Peter Maydell
2013-06-13 13:25 ` [Qemu-devel] [PATCH v2] " Mans Rullgard
2013-06-13 14:01 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B9C5F1.2020503@suse.de \
--to=afaerber@suse.de \
--cc=mans@mansr.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).