From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47441)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Un9z0-0007bD-Jg
	for qemu-devel@nongnu.org; Thu, 13 Jun 2013 12:02:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Un9yw-0006ix-KO
	for qemu-devel@nongnu.org; Thu, 13 Jun 2013 12:02:42 -0400
Received: from mail-vb0-x22d.google.com ([2607:f8b0:400c:c02::22d]:32945)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Un9yw-0006i7-9u
	for qemu-devel@nongnu.org; Thu, 13 Jun 2013 12:02:38 -0400
Received: by mail-vb0-f45.google.com with SMTP id p14so5001993vbm.32
	for <qemu-devel@nongnu.org>; Thu, 13 Jun 2013 09:02:36 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51B9ED17.4060305@twiddle.net>
Date: Thu, 13 Jun 2013 09:02:31 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1371106939-6968-1-git-send-email-armbru@redhat.com>
	<1371106939-6968-8-git-send-email-armbru@redhat.com>
In-Reply-To: <1371106939-6968-8-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC 7/8] exec: Don't abort when we can't
 allocate guest memory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: stefano.stabellini@eu.citrix.com, mtosatti@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, pbonzini@redhat.com

On 06/13/2013 12:02 AM, Markus Armbruster wrote:
> @@ -945,7 +952,7 @@ static void *file_ram_alloc(RAMBlock *block,
>      area = mmap(0, memory, PROT_READ | PROT_WRITE, MAP_PRIVATE, fd, 0);
>  #endif
>      if (area == MAP_FAILED) {
> -        perror("file_ram_alloc: can't mmap RAM pages");
> +        no_guest_mem(block);
>          close(fd);
>          return (NULL);
>      }

Dead code after no_guest_mem.


r~