From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnFdN-0008Rw-Ld for qemu-devel@nongnu.org; Thu, 13 Jun 2013 18:04:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UnFdM-0003r6-Qg for qemu-devel@nongnu.org; Thu, 13 Jun 2013 18:04:45 -0400 Received: from mail-qa0-x22c.google.com ([2607:f8b0:400d:c00::22c]:38796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnFdM-0003qy-MM for qemu-devel@nongnu.org; Thu, 13 Jun 2013 18:04:44 -0400 Received: by mail-qa0-f44.google.com with SMTP id j8so1409296qah.10 for ; Thu, 13 Jun 2013 15:04:44 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51BA41F9.4040801@redhat.com> Date: Thu, 13 Jun 2013 18:04:41 -0400 From: Paolo Bonzini MIME-Version: 1.0 References: <20130613125906.GA32223@redhat.com> In-Reply-To: <20130613125906.GA32223@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] exec: move io_mem_read/write to memory.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Anthony Liguori , qemu-devel@nongnu.org Il 13/06/2013 08:59, Michael S. Tsirkin ha scritto: > implementation is in memory.c, move function > to match. This allows use from places that > don't pull in exec-all.h But they shouldn't be used. :) Everything except the current users (TCG, and address_space_rw and friends) should go through exec.c. Paolo > Signed-off-by: Michael S. Tsirkin > --- > > include/exec/exec-all.h | 5 ----- > include/exec/memory.h | 5 +++++ > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h > index 6362074..28cb37d 100644 > --- a/include/exec/exec-all.h > +++ b/include/exec/exec-all.h > @@ -367,11 +367,6 @@ bool is_tcg_gen_code(uintptr_t pc_ptr); > #if !defined(CONFIG_USER_ONLY) > > struct MemoryRegion *iotlb_to_region(hwaddr index); > -uint64_t io_mem_read(struct MemoryRegion *mr, hwaddr addr, > - unsigned size); > -void io_mem_write(struct MemoryRegion *mr, hwaddr addr, > - uint64_t value, unsigned size); > - > void tlb_fill(CPUArchState *env1, target_ulong addr, int is_write, int mmu_idx, > uintptr_t retaddr); > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 9e88320..edeb1f2 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -888,6 +888,11 @@ void address_space_unmap(AddressSpace *as, void *buffer, hwaddr len, > int is_write, hwaddr access_len); > > > +uint64_t io_mem_read(struct MemoryRegion *mr, hwaddr addr, > + unsigned size); > +void io_mem_write(struct MemoryRegion *mr, hwaddr addr, > + uint64_t value, unsigned size); > + > #endif > > #endif >