From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32814)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UnFij-0002r1-7Z
	for qemu-devel@nongnu.org; Thu, 13 Jun 2013 18:10:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UnFii-00066p-9z
	for qemu-devel@nongnu.org; Thu, 13 Jun 2013 18:10:17 -0400
Received: from mail-qc0-x22c.google.com ([2607:f8b0:400d:c01::22c]:59715)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UnFii-00066l-50
	for qemu-devel@nongnu.org; Thu, 13 Jun 2013 18:10:16 -0400
Received: by mail-qc0-f172.google.com with SMTP id j10so6239848qcx.31
	for <qemu-devel@nongnu.org>; Thu, 13 Jun 2013 15:10:15 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51BA4344.7070608@redhat.com>
Date: Thu, 13 Jun 2013 18:10:12 -0400
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1371124063-12971-1-git-send-email-kwolf@redhat.com>
	<1371124063-12971-4-git-send-email-kwolf@redhat.com>
In-Reply-To: <1371124063-12971-4-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/5] qcow2: Options to enable discard for
	freed clusters
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

Il 13/06/2013 07:47, Kevin Wolf ha scritto:
> +    s->discard_passthrough[QCOW2_DISCARD_NEVER] = false,
> +    s->discard_passthrough[QCOW2_DISCARD_ALWAYS] = true,
> +    s->discard_passthrough[QCOW2_DISCARD_REQUEST] =
> +        qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_REQUEST,
> +                          flags & BDRV_O_UNMAP),

I think there should not be two ways to enable it, it is confusing.

> +    s->discard_passthrough[QCOW2_DISCARD_SNAPSHOT] =
> +        qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_SNAPSHOT, true),
> +    s->discard_passthrough[QCOW2_DISCARD_OTHER] =
> +        qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_OTHER, false),

Please document the defaults in qcow2_runtime_opts.  (BTW, what is the
rationale?)

Paolo