From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34530)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UnFtV-0007Yb-UR
	for qemu-devel@nongnu.org; Thu, 13 Jun 2013 18:21:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UnFtV-0001NZ-7L
	for qemu-devel@nongnu.org; Thu, 13 Jun 2013 18:21:25 -0400
Received: from mail-qa0-x230.google.com ([2607:f8b0:400d:c00::230]:34333)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UnFtV-0001NR-34
	for qemu-devel@nongnu.org; Thu, 13 Jun 2013 18:21:25 -0400
Received: by mail-qa0-f48.google.com with SMTP id cm16so1402138qab.7
	for <qemu-devel@nongnu.org>; Thu, 13 Jun 2013 15:21:24 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51BA45E1.4030500@redhat.com>
Date: Thu, 13 Jun 2013 18:21:21 -0400
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1371106939-6968-1-git-send-email-armbru@redhat.com>
	<1371106939-6968-7-git-send-email-armbru@redhat.com>
In-Reply-To: <1371106939-6968-7-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC 6/8] exec: Clean up unnecessary S390
	ifdeffery
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: borntraeger@de.ibm.com, mtosatti@redhat.com, qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com, agraf@suse.de

Il 13/06/2013 03:02, Markus Armbruster ha scritto:
> +    } else if (kvm_enabled() && kvm_arch_ram_alloc) {
> +        /* some s390/kvm configurations have special constraints */
> +        if (mem_path) {
> +            fprintf(stderr,
> +                    "-mem-path not supported with this version of KVM\n");
> +            exit(1);
> +        }
> +        new_block->host = kvm_arch_ram_alloc(size);
> +        memory_try_enable_merging(new_block->host, size);

Uh oh, now I see why you wanted the hook as a function pointer.  Can you
instead pass the file descriptor to kvm_ram_alloc?

Paolo