Re: [Qemu-devel] [Qemu-trivial] [PATCH] cputlb: fix debug logs

["Andreas Färber" <afaerber@suse.de>]

Am 05.06.2013 21:51, schrieb Michael Tokarev:
> 05.06.2013 16:16, Hervé Poussineau wrote:
>> 'pd' variable has been removed in 06ef3525e1f271b6a842781a05eace5cf63b95c2.
> 
> It's been removed indeed, but the value has been replaced by using
> a MemoryRegionSection instead.  I understand current code is wrong
> when DEBUG_TLB is #defined, but I think it is also wrong to just
> remove this value in printf.  The question is whenever this debugging
> is useful now, and whenever this now-missing value is interesting
> for that and should be provided by other means.  Maybe we may just
> remove whole thing here and everywhere.

I interpret it as logging the function arguments, so dropping it sounded
like the right solution to me. Would be nice to turn it into a
tracepoint or at least some DPRINTF() macro that gets compile-tested.

Andreas

> 
> Cc'ing authors.
> 
> While this patch looks really trivial, it is something which is of
> use by the subsystem maintainer(s) at their disposal.
> 
> Thanks,
> 
> /mjt
> 
>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>> ---
>>  cputlb.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/cputlb.c b/cputlb.c
>> index 86666c8..1230e9e 100644
>> --- a/cputlb.c
>> +++ b/cputlb.c
>> @@ -262,8 +262,8 @@ void tlb_set_page(CPUArchState *env, target_ulong vaddr,
>>  
>>  #if defined(DEBUG_TLB)
>>      printf("tlb_set_page: vaddr=" TARGET_FMT_lx " paddr=0x" TARGET_FMT_plx
>> -           " prot=%x idx=%d pd=0x%08lx\n",
>> -           vaddr, paddr, prot, mmu_idx, pd);
>> +           " prot=%x idx=%d\n",
>> +           vaddr, paddr, prot, mmu_idx);
>>  #endif
>>  
>>      address = vaddr;
>>
> 
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg