From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnmRh-0006Tr-4u for qemu-devel@nongnu.org; Sat, 15 Jun 2013 05:06:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UnmRg-0007iE-1D for qemu-devel@nongnu.org; Sat, 15 Jun 2013 05:06:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42465) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnmRf-0007gz-NB for qemu-devel@nongnu.org; Sat, 15 Jun 2013 05:06:51 -0400 Message-ID: <51BC2EA5.30205@redhat.com> Date: Sat, 15 Jun 2013 10:06:45 +0100 From: Eric Blake MIME-Version: 1.0 References: <1371242153-11262-1-git-send-email-mrhines@linux.vnet.ibm.com> <1371242153-11262-15-git-send-email-mrhines@linux.vnet.ibm.com> In-Reply-To: <1371242153-11262-15-git-send-email-mrhines@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2WHTBWGVFUTKJUVIKPTWD" Subject: Re: [Qemu-devel] [PATCH v9 14/14] rdma: add pin-all accounting timestamp to QMP statistics List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrhines@linux.vnet.ibm.com Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com, knoel@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2WHTBWGVFUTKJUVIKPTWD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/14/2013 09:35 PM, mrhines@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" >=20 > For very large virtual machines, pinning can take a long time. > While this does not affect the migration's *actual* time itself, > it is still important for the user to know what's going on and > to know what component of the total time is actual taken up by > pinning. >=20 > For example, using a 14GB virtual machine, pinning can take as > long as 5 seconds, for which the user would not otherwise know > what was happening. >=20 > Reviewed-by: Paolo Bonzini > Signed-off-by: Michael R. Hines > --- > +++ b/qapi-schema.json > @@ -586,7 +586,8 @@ > '*xbzrle-cache': 'XBZRLECacheStats', > '*total-time': 'int', > '*expected-downtime': 'int', > - '*downtime': 'int'} } > + '*downtime': 'int', > + '*pin-all-time' : 'int'} } Missing documentation of the new field (compare how @downtime is documented as a (since 1.3) field). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2WHTBWGVFUTKJUVIKPTWD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRvC6lAAoJEKeha0olJ0Nqf2cH/jWKsshXbKVOJ4VqqN+GRKnF JH5H/T5FTt6nYDo8FZPlTUg6ke1+neudOigghvEOi9JLHawGW24Awfn2c9gGtB7f hizWH6n/Qf0Vb6KY1N0ghO0XJcHFAP6BO92lqr3Llb6RSGGGKTd9i8htTNw/vxlU uClIpOcpEHPM8VnsoXTPj+/fOzfw4ngRzBbA1vaFk/SG60tq55TAG3FfGuGePpVa mE55iLOotgf0l8DPpsbsQtbTNajNPIuEOLn7pAEJLRrDqfr9eTpKT5D+3958YdMc wZ2ZHmYses2+B2lyMtyggmAUuLDl+0zOUTm5iPmynH53zvpvOkYTNtaHKeBCxi8= =G5+S -----END PGP SIGNATURE----- ------enig2WHTBWGVFUTKJUVIKPTWD--