From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnsGm-0000WD-SU for qemu-devel@nongnu.org; Sat, 15 Jun 2013 11:20:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UnsGl-0003jL-WD for qemu-devel@nongnu.org; Sat, 15 Jun 2013 11:20:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnsGl-0003jH-N8 for qemu-devel@nongnu.org; Sat, 15 Jun 2013 11:19:59 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5FFJwJ9017769 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 15 Jun 2013 11:19:59 -0400 Message-ID: <51BC861D.7030100@redhat.com> Date: Sat, 15 Jun 2013 16:19:57 +0100 From: Eric Blake MIME-Version: 1.0 References: <1370533048-19229-1-git-send-email-kraxel@redhat.com> <1370533048-19229-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1370533048-19229-2-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2DKOADXDPTELFNEGLFMMP" Subject: Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor command to enable/disable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2DKOADXDPTELFNEGLFMMP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/06/2013 04:37 PM, Gerd Hoffmann wrote: > This patch adds a fbdev monitor command to enable/disable > the fbdev display at runtime to both qmp and hmp. >=20 > qmp: framebuffer-display enable=3Don|off scale=3Don|off device=3D/dev/f= b > hmp: framebuffer-display on|off >=20 > Signed-off-by: Gerd Hoffmann > --- > +++ b/qapi-schema.json > @@ -3618,3 +3618,23 @@ > '*cpuid-input-ecx': 'int', > 'cpuid-register': 'X86CPURegister32', > 'features': 'int' } } > + > +## > +# @framebuffer-display: > +# > +# Enable/disable linux console framebuffer display. > +# > +# @enable: whenever the framebuffer display should be enabled or disab= led. s/whenever/whether/ > +# > +# @scale: #optional enables display scaling, default: off > +# > +# @device: #optional specifies framebuffer device, default: /dev/fb0 > +# > +# Returns: Nothing. > +# > +# Since: 1.6 > +# > +## > +{ 'command': 'framebuffer-display', 'data': {'enable' : 'bool', > + '*scale' : 'bool', > + '*device' : 'str' } } I'm not a fan of write-only interfaces. Where is the corresponding query- command that tells me the current settings? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2DKOADXDPTELFNEGLFMMP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRvIYdAAoJEKeha0olJ0NqhGsIAJb147EHa7zM2zBHCHXYKsi/ 5M9fVdwlwRg4t5n2p+1ZS/vAKnSVA7GqmDlXMxVdCe1lcKH7VevpTRb54E4FFdss iAumDu1nUtZYeLp35Muvc48ykxeJZQrBBpWoCb2wZe9YRbPeQXB0Nz1+GAXzb539 jhlXt9/J6PkcseA6WXyyLXDGsbOIvMLiBse16lO0ba3CIoNXFBDqHSDtvKFCOMRE n+sEfjiwjdSVzvStHyLzIIIPuYx49DbmfOv308D9m+WiwMBmHBPhCtBgsFhO1Sy8 wTIWKRB13J13P3y6WMM7KqC9i5eZBMC5zutoEBQwkRebrSfbHKDGdp3kpHejG8A= =AelI -----END PGP SIGNATURE----- ------enig2DKOADXDPTELFNEGLFMMP--