From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnsOz-0002oi-CK for qemu-devel@nongnu.org; Sat, 15 Jun 2013 11:28:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UnsOy-0006ah-5H for qemu-devel@nongnu.org; Sat, 15 Jun 2013 11:28:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnsOx-0006aa-TQ for qemu-devel@nongnu.org; Sat, 15 Jun 2013 11:28:28 -0400 Message-ID: <51BC880D.8010106@redhat.com> Date: Sat, 15 Jun 2013 16:28:13 +0100 From: Eric Blake MIME-Version: 1.0 References: <1370507765-2806-1-git-send-email-pl@kamp.de> <1370507765-2806-2-git-send-email-pl@kamp.de> <1586032558.12669884.1370520984709.JavaMail.root@redhat.com> <51B09C19.8090002@dlhnet.de> In-Reply-To: <51B09C19.8090002@dlhnet.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2OVGBFUHGMRQIRDQHAOHH" Subject: Re: [Qemu-devel] [PATCH 1/2] Revert "migration: do not sent zero pages in bulk stage" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: aik@ozlabs.ru, pbonzini@redhat.com, Peter Lieven , qemu-devel@nongnu.org, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2OVGBFUHGMRQIRDQHAOHH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/06/2013 03:26 PM, Peter Lieven wrote: >>> @@ -514,8 +512,8 @@ >>> ## >>> { 'type': 'MigrationStats', >>> 'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int'= , >>> - 'duplicate': 'int', 'skipped': 'int', 'normal': 'int', >>> - 'normal-bytes': 'int', 'dirty-pages-rate' : 'int' } } >>> + 'duplicate': 'int', 'normal': 'int', 'normal-bytes': 'int= ', >>> + 'dirty-pages-rate' : 'int' } } >> This hunk is questionable. Removing something that we have previously= >> sent >> over the wire may break clients that are expecting this field to exist= =2E >> Rather than reverting the entire patch, you should consider keeping th= is >> field present in QMP, even if you now always populate it with 0. >> > You are right. I might still account zero pages in the bulk phase to > give this > field a meaning. These pages are very likely not written on the > destination except > for the cornercases. What do you think? I don't care if you document a slightly different meaning for the statistic; as long as it is documented. Where I do care is removing something that previous versions provided; I think your later versions of this series adequately took care of this by reverting only a subset of the original patch. I'm okay with the current qemu.git behavior that always displays returns "skipped":0, or if you post a later patch that again makes it print a non-zero number that you find useful. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2OVGBFUHGMRQIRDQHAOHH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRvIgNAAoJEKeha0olJ0NqJysH/jAxwtTw0oX1MPXJp5Oxvqla XGXe6dLQSDR0R3ztFITby5gRKu38bMYE1FZ+VRB6XOoPtVnZZKAOdtEcnfL3TDOD k8PlMmwGSYbYOSEJSmFoEb1OF6HQQ4352kXSuSil07cGAPEN1U09wlhY97A77Kxw hW1ETz2FMRbIrwU1I1cs8rguE+JRsCY+oRq+qoGvY3YIyP9HbA4CXE4RAIOwYiV4 mBJxB3uMdoiH1hKDyqAJeNDjQ4aOt1hf7xUhXCCVoiizsj+zvL1GlU4DzB5BIOd+ vXAfpSXH4/x9KH2YO0T/iXl/hiWaEMpKUZ9/B18FH/XslZxUTdWVU6xp9MJHr1M= =loiP -----END PGP SIGNATURE----- ------enig2OVGBFUHGMRQIRDQHAOHH--