From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnuLh-0001Uu-5N for qemu-devel@nongnu.org; Sat, 15 Jun 2013 13:33:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UnuLf-0002yc-Ro for qemu-devel@nongnu.org; Sat, 15 Jun 2013 13:33:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnuLf-0002yN-Kq for qemu-devel@nongnu.org; Sat, 15 Jun 2013 13:33:11 -0400 Message-ID: <51BCA54A.1020509@redhat.com> Date: Sat, 15 Jun 2013 13:32:58 -0400 From: Paolo Bonzini MIME-Version: 1.0 References: <1371242153-11262-1-git-send-email-mrhines@linux.vnet.ibm.com> <1371242153-11262-15-git-send-email-mrhines@linux.vnet.ibm.com> <51BC2EA5.30205@redhat.com> In-Reply-To: <51BC2EA5.30205@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v9 14/14] rdma: add pin-all accounting timestamp to QMP statistics List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, quintela@redhat.com, knoel@redhat.com, mrhines@linux.vnet.ibm.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, chegu_vinod@hp.com Il 15/06/2013 05:06, Eric Blake ha scritto: > On 06/14/2013 09:35 PM, mrhines@linux.vnet.ibm.com wrote: >> From: "Michael R. Hines" >> >> For very large virtual machines, pinning can take a long time. >> While this does not affect the migration's *actual* time itself, >> it is still important for the user to know what's going on and to >> know what component of the total time is actual taken up by >> pinning. >> >> For example, using a 14GB virtual machine, pinning can take as >> long as 5 seconds, for which the user would not otherwise know >> what was happening. >> >> Reviewed-by: Paolo Bonzini Signed-off-by: >> Michael R. Hines --- > >> +++ b/qapi-schema.json @@ -586,7 +586,8 @@ '*xbzrle-cache': >> 'XBZRLECacheStats', '*total-time': 'int', '*expected-downtime': >> 'int', - '*downtime': 'int'} } + '*downtime': >> 'int', + '*pin-all-time' : 'int'} } > > Missing documentation of the new field (compare how @downtime is > documented as a (since 1.3) field). > Can you just time the setup phase instead? Paolo