From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40797)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1Unv5B-0001uB-Ka
	for qemu-devel@nongnu.org; Sat, 15 Jun 2013 14:20:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1Unv58-0000gC-QH
	for qemu-devel@nongnu.org; Sat, 15 Jun 2013 14:20:13 -0400
Message-ID: <51BCB04A.9090401@reactos.org>
Date: Sat, 15 Jun 2013 20:19:54 +0200
From: =?ISO-8859-1?Q?Herv=E9_Poussineau?= <hpoussin@reactos.org>
MIME-Version: 1.0
References: <1368299031-17587-1-git-send-email-hpoussin@reactos.org>
	<519A68CB.2040406@reactos.org> <20130611214241.GA13030@vm>
In-Reply-To: <20130611214241.GA13030@vm>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH for-1.5] ppc: do not register
 IABR SPR	twice for 603e
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: mdroth <mdroth@linux.vnet.ibm.com>
Cc: qemu-stable@nongnu.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

mdroth a =E9crit :
> On Mon, May 20, 2013 at 08:17:47PM +0200, Herv=E9 Poussineau wrote:
>> Ping.
>> This should be IMO committed to stable, as it fixes a crash with
>> qemu-system-ppc -M prep -cpu 603e
>=20
> Ping^2. Looking to pull this in for 1.5.1

Ping^3

>=20
>> Herv=E9
>>
>> Herv=E9 Poussineau a =E9crit :
>>> IABR SPR is already registered in gen_spr_603(), called from init_pro=
c_603E().
>>>
>>> Signed-off-by: Herv=E9 Poussineau <hpoussin@reactos.org>
>>> ---
>>> target-ppc/translate_init.c |    5 -----
>>> 1 file changed, 5 deletions(-)
>>>
>>> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.=
c
>>> index 6feb62a..248d3e0 100644
>>> --- a/target-ppc/translate_init.c
>>> +++ b/target-ppc/translate_init.c
>>> @@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
>>>                  SPR_NOACCESS, SPR_NOACCESS,
>>>                  &spr_read_generic, &spr_write_generic,
>>>                  0x00000000);
>>> -    /* XXX : not implemented */
>>> -    spr_register(env, SPR_IABR, "IABR",
>>> -                 SPR_NOACCESS, SPR_NOACCESS,
>>> -                 &spr_read_generic, &spr_write_generic,
>>> -                 0x00000000);
>>>     /* Memory management */
>>>     gen_low_BATs(env);
>>>     gen_6xx_7xx_soft_tlb(env, 64, 2);
>>
>=20