From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uo4Ek-0006xG-7C for qemu-devel@nongnu.org; Sun, 16 Jun 2013 00:06:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uo4Eh-0003gx-GZ for qemu-devel@nongnu.org; Sun, 16 Jun 2013 00:06:42 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:59675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uo4Eh-0003gs-AA for qemu-devel@nongnu.org; Sun, 16 Jun 2013 00:06:39 -0400 Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 15 Jun 2013 22:06:38 -0600 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 756051FF0020 for ; Sat, 15 Jun 2013 22:01:21 -0600 (MDT) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5G46YrH104546 for ; Sat, 15 Jun 2013 22:06:34 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5G46XeH018972 for ; Sat, 15 Jun 2013 22:06:34 -0600 Message-ID: <51BD39C8.1060109@linux.vnet.ibm.com> Date: Sun, 16 Jun 2013 00:06:32 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1371242153-11262-1-git-send-email-mrhines@linux.vnet.ibm.com> <1371242153-11262-15-git-send-email-mrhines@linux.vnet.ibm.com> <51BC2EA5.30205@redhat.com> <51BCA54A.1020509@redhat.com> In-Reply-To: <51BCA54A.1020509@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v9 14/14] rdma: add pin-all accounting timestamp to QMP statistics List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, quintela@redhat.com, chegu_vinod@hp.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, knoel@redhat.com On 06/15/2013 01:32 PM, Paolo Bonzini wrote: > Il 15/06/2013 05:06, Eric Blake ha scritto: >> On 06/14/2013 09:35 PM, mrhines@linux.vnet.ibm.com wrote: >>> From: "Michael R. Hines" >>> >>> For very large virtual machines, pinning can take a long time. >>> While this does not affect the migration's *actual* time itself, >>> it is still important for the user to know what's going on and to >>> know what component of the total time is actual taken up by >>> pinning. >>> >>> For example, using a 14GB virtual machine, pinning can take as >>> long as 5 seconds, for which the user would not otherwise know >>> what was happening. >>> >>> Reviewed-by: Paolo Bonzini Signed-off-by: >>> Michael R. Hines --- >>> +++ b/qapi-schema.json @@ -586,7 +586,8 @@ '*xbzrle-cache': >>> 'XBZRLECacheStats', '*total-time': 'int', '*expected-downtime': >>> 'int', - '*downtime': 'int'} } + '*downtime': >>> 'int', + '*pin-all-time' : 'int'} } >> Missing documentation of the new field (compare how @downtime is >> documented as a (since 1.3) field). >> > Can you just time the setup phase instead? > > Paolo > That's a great idea..... better to make it a more generic time. I'll send out a V10 with everybody's suggestions. - Michael