From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoFvC-0003AF-79 for qemu-devel@nongnu.org; Sun, 16 Jun 2013 12:35:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UoFvA-0002xq-On for qemu-devel@nongnu.org; Sun, 16 Jun 2013 12:35:18 -0400 Message-ID: <51BDE93F.20809@suse.de> Date: Sun, 16 Jun 2013 18:35:11 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1370805206-26574-1-git-send-email-afaerber@suse.de> <1370805206-26574-26-git-send-email-afaerber@suse.de> <1370918365.21655.69.camel@liguang.fnst.cn.fujitsu.com> <51BD76F1.1050104@suse.de> In-Reply-To: <51BD76F1.1050104@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 25/59] cpu: Change qemu_init_vcpu() argument to CPUState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: li guang Cc: Peter Maydell , Anthony Green , qemu-devel@nongnu.org, Alexander Graf , Blue Swirl , Max Filippov , Michael Walle , qemu-ppc , Paul Brook , "Edgar E. Iglesias" , Guan Xuetao , Aurelien Jarno , Richard Henderson Am 16.06.2013 10:27, schrieb Andreas F=C3=A4rber: > =E5=97=A8, >=20 > Am 11.06.2013 04:39, schrieb li guang: >> =E5=9C=A8 2013-06-09=E6=97=A5=E7=9A=84 21:12 +0200=EF=BC=8CAndreas F=C3= =A4rber=E5=86=99=E9=81=93=EF=BC=9A >>> This allows to move the call to CPUState's realizefn. >>> Therefore move the stub into libqemustub.a. >>> >>> Signed-off-by: Andreas F=C3=A4rber >> [...]=20 >>> diff --git a/target-arm/cpu.c b/target-arm/cpu.c >>> index a40290c..88ee61b 100644 >>> --- a/target-arm/cpu.c >>> +++ b/target-arm/cpu.c >>> @@ -205,7 +205,6 @@ static void arm_cpu_realizefn(DeviceState *dev, E= rror **errp) >>> arm_cpu_register_gdb_regs_for_features(cpu); >>> =20 >>> cpu_reset(CPU(cpu)); >> >> can this and following 'cpu_reset' also be moved to >> 'cpu_common_realizefn' like 'qemu_init_vcpu'? >=20 > I have a branch qom-cpu-reset that tried this. However the culprit was > that alpha reset was broken and we have not yet fully fixed it. > I.e., through the memset() up to "breakpoints" some pointers would get > overridden, so calling it is not a good idea at the moment. But if you > have some spare time and an alpha guest... ;) Sorry. While the above is still an issue, the reason for not being able to make the change yet were rather sparc and ppc, who do not reset on creation today. For alpha it would simply be a no-op today due to lack of reset (experimental implementation on qom-cpu-alpha branch). Andreas > I chose to leave the cpu_index logging line in place until I can move i= t > together with log_cpu_state() (depended on patch 18/59), for which I > have a patch on qom-cpu-11 branch. :) >=20 > Cheers, > Andreas >=20 >>> - qemu_init_vcpu(env); >>> =20 >>> acc->parent_realize(dev, errp); >>> } > [snip] >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg