From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoIZa-0006kY-B3 for qemu-devel@nongnu.org; Sun, 16 Jun 2013 15:25:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UoIZZ-0003Df-5Y for qemu-devel@nongnu.org; Sun, 16 Jun 2013 15:25:10 -0400 Message-ID: <51BE1110.5000107@suse.de> Date: Sun, 16 Jun 2013 21:25:04 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1371069171-20377-1-git-send-email-scottwood@freescale.com> In-Reply-To: <1371069171-20377-1-git-send-email-scottwood@freescale.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] kvm/openpic: in-kernel mpic support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Scott Wood , Alexander Graf Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org Subject is misleading: it's intc/openpic_kvm, not kvm/openpic. Alex, please fix when squashing. Am 12.06.2013 22:32, schrieb Scott Wood: > Enables support for the in-kernel MPIC that thas been merged into the > KVM next branch. This includes irqfd/KVM_IRQ_LINE support from Alex > Graf (along with some other improvements). >=20 > Note from Alex regarding kvm_irqchip_create(): >=20 > On x86, one would call kvm_irqchip_create() to initialize an > in-kernel interrupt controller. That function then goes ahead and > initializes global capability variables as well as the default irq > routing table. >=20 > On ppc, we can't call kvm_irqchip_create() because we can have > different types of interrupt controllers. So we want to do all the > things that function would do for us in the in-kernel device init > handler. >=20 > Signed-off-by: Scott Wood > --- > v2: fix "llx" -> PRI_x64, and remove some broken leftover code > involving reg_base. > --- > default-configs/ppc-softmmu.mak | 1 + > default-configs/ppc64-softmmu.mak | 1 + This breaks KVM-enabled ppcemb-softmmu build with unresolved symbol kvm_openpic_connect_vcpu() in e500.o. Fix in my patch: http://patchwork.ozlabs.org/patch/251731/ Because intc/openpic.c gets rebuilt for each of the three ppc*-softmmu, I added a patch to my qom-cpu-10 series to stop that for openpic. For openpic_kvm I believe that won't be possible due to sysemu/kvm.h's inline stubs. Andreas > hw/intc/Makefile.objs | 1 + > hw/intc/openpic_kvm.c | 250 +++++++++++++++++++++++++++++= ++++++++ > hw/ppc/e500.c | 79 +++++++++++- > include/hw/ppc/openpic.h | 2 +- > 6 files changed, 328 insertions(+), 6 deletions(-) > create mode 100644 hw/intc/openpic_kvm.c --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg