From: Gerd Hoffmann <kraxel@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Brad Hards <bradh@frogmouth.net>,
qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Ludwig Nussel <lnussel@suse.de>
Subject: Re: [Qemu-devel] [PATCH RFC 2/8] ui/input: Simplify kbd_mouse_event()
Date: Mon, 17 Jun 2013 09:17:33 +0200 [thread overview]
Message-ID: <51BEB80D.8050902@redhat.com> (raw)
In-Reply-To: <1371354005-26873-3-git-send-email-afaerber@suse.de>
On 06/16/13 05:39, Andreas Färber wrote:
> Now that the field names are bearable, there's no compelling reason to
> use local variables for the fields.
>
> Unify the four callback invokations through variables for the rotated
> coordinates instead.
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
cheers,
Gerd
next prev parent reply other threads:[~2013-06-17 7:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 3:39 [Qemu-devel] [PATCH RFC 0/8] monitor: Fix mouse_button and improve mouse_move commands Andreas Färber
2013-06-16 3:39 ` [Qemu-devel] [PATCH RFC 1/8] ui/input: Clean up QEMUPutMouseEntry struct Andreas Färber
2013-06-17 7:17 ` Gerd Hoffmann
2013-06-16 3:39 ` [Qemu-devel] [PATCH RFC 2/8] ui/input: Simplify kbd_mouse_event() Andreas Färber
2013-06-17 7:17 ` Gerd Hoffmann [this message]
2013-06-16 3:40 ` [Qemu-devel] [PATCH RFC 3/8] ui/input: Use bool for qemu_add_mouse_event_handler() Andreas Färber
2013-06-16 3:40 ` [Qemu-devel] [PATCH RFC 4/8] ui/input: Introduce MouseOps " Andreas Färber
2013-06-17 7:20 ` Gerd Hoffmann
2013-06-16 3:40 ` [Qemu-devel] [PATCH RFC 5/8] ui/input: Introduce MouseOps::get_buttons_state() Andreas Färber
2013-06-16 3:40 ` [Qemu-devel] [PATCH RFC 6/8] monitor: Eliminate global mouse buttons state for mouse_move Andreas Färber
2013-06-16 3:40 ` [Qemu-devel] [PATCH RFC 7/8] ui/input: Introduce MouseOps::get_position() Andreas Färber
2013-06-16 3:40 ` [Qemu-devel] [PATCH RFC 8/8] monitor: Fix mouse_button command for absolute coordinates Andreas Färber
2013-06-17 7:16 ` [Qemu-devel] [PATCH RFC 0/8] monitor: Fix mouse_button and improve mouse_move commands Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BEB80D.8050902@redhat.com \
--to=kraxel@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=bradh@frogmouth.net \
--cc=lcapitulino@redhat.com \
--cc=lnussel@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).