From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoThC-0006au-T0 for qemu-devel@nongnu.org; Mon, 17 Jun 2013 03:17:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UoThB-0005QO-OA for qemu-devel@nongnu.org; Mon, 17 Jun 2013 03:17:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18843) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoThB-0005QH-Gw for qemu-devel@nongnu.org; Mon, 17 Jun 2013 03:17:45 -0400 Message-ID: <51BEB80D.8050902@redhat.com> Date: Mon, 17 Jun 2013 09:17:33 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1371354005-26873-1-git-send-email-afaerber@suse.de> <1371354005-26873-3-git-send-email-afaerber@suse.de> In-Reply-To: <1371354005-26873-3-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 2/8] ui/input: Simplify kbd_mouse_event() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Anthony Liguori , Brad Hards , qemu-devel@nongnu.org, Luiz Capitulino , Paolo Bonzini , Ludwig Nussel On 06/16/13 05:39, Andreas F=C3=A4rber wrote: > Now that the field names are bearable, there's no compelling reason to > use local variables for the fields. >=20 > Unify the four callback invokations through variables for the rotated > coordinates instead. Reviewed-by: Gerd Hoffmann cheers, Gerd