From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37245)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UoYFO-0003Ua-9X
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 08:09:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UoYFE-0005Lz-UA
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 08:09:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53848)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UoYFE-0005Li-M5
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 08:09:12 -0400
Message-ID: <51BEFC62.6080109@redhat.com>
Date: Mon, 17 Jun 2013 14:09:06 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1328704089-18691-1-git-send-email-kraxel@redhat.com>
	<77c7f18a4c427a64b1d16821b631e758.squirrel@ssl.dlhnet.de>
	<51BECD7E.4090305@redhat.com> <51BEED6D.7000008@dlhnet.de>
In-Reply-To: <51BEED6D.7000008@dlhnet.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client
	disconnect.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@dlhnet.de>
Cc: Peter Lieven <lieven@dlhnet.de>, qemu-devel@nongnu.org

On 06/17/13 13:05, Peter Lieven wrote:
> Am 17.06.2013 10:49, schrieb Gerd Hoffmann:
>> On 06/17/13 10:10, Peter Lieven wrote:
>>> Hi Gerd,
>>>
>>> just looking at your patch. It works fine so far, but I am curious how
>>> to handle the lock keys? I have the problem that if I press caps lock
>>> and then create a new vnc session with exclusive access (from another
>>> terminal), the caps lock is still there.
>>
>> There is some logic for that in the vnc server, next time you press a
>> letter key it should get synced up.  capslock+numlock can actually
>> easier go out of sync than the other modifiers, you don't need a
>> reconnect to trigger that:  Activate some other window so the vnc client
>> window so it hasn't the keyboard focus, press capslock or numlock, move
>> focus back to the vnc window.
> 
> It seems the sync logic fails iff.
>  Caps Lock enabled -> VNC Disconnect -> Caps Lock disabled -> VNC Reconnect.
>  In this case the guest OS is still typing uppercase letters.

I guess reset_keys() should skip capslock+numlock to not disturb the
sync logic, can you try that?

cheers,
 Gerd