From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Lieven <pl@dlhnet.de>
Cc: Peter Lieven <lieven@dlhnet.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.
Date: Mon, 17 Jun 2013 15:58:56 +0200 [thread overview]
Message-ID: <51BF1620.1020608@redhat.com> (raw)
In-Reply-To: <51BF0D1C.7080601@dlhnet.de>
Hi,
>> I guess reset_keys() should skip capslock+numlock to not disturb the
>> sync logic, can you try that?
>
> mhh, i might be wrong, but where could the vs->modifiers_state be not zero
> on a new connection. I only find a g_malloc0 initializing the VNCState.
Ah, right, it is in the per-connection vnc state not in the
server-global vnc state. Yes, I guess we should store ledstate in
VncDisplay then, so we can call kbd_leds() on new connections.
cheers,
Gerd
next prev parent reply other threads:[~2013-06-17 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 12:28 [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect Gerd Hoffmann
2013-06-17 8:10 ` Peter Lieven
2013-06-17 8:49 ` Gerd Hoffmann
2013-06-17 11:05 ` Peter Lieven
2013-06-17 12:09 ` Gerd Hoffmann
2013-06-17 13:20 ` Peter Lieven
2013-06-17 13:58 ` Gerd Hoffmann [this message]
2013-06-17 15:38 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BF1620.1020608@redhat.com \
--to=kraxel@redhat.com \
--cc=lieven@dlhnet.de \
--cc=pl@dlhnet.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).