From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoZxZ-0005dJ-1O for qemu-devel@nongnu.org; Mon, 17 Jun 2013 09:59:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UoZxW-0007Ng-SS for qemu-devel@nongnu.org; Mon, 17 Jun 2013 09:59:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoZxW-0007NC-Kc for qemu-devel@nongnu.org; Mon, 17 Jun 2013 09:59:02 -0400 Message-ID: <51BF1620.1020608@redhat.com> Date: Mon, 17 Jun 2013 15:58:56 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1328704089-18691-1-git-send-email-kraxel@redhat.com> <77c7f18a4c427a64b1d16821b631e758.squirrel@ssl.dlhnet.de> <51BECD7E.4090305@redhat.com> <51BEED6D.7000008@dlhnet.de> <51BEFC62.6080109@redhat.com> <51BF0D1C.7080601@dlhnet.de> In-Reply-To: <51BF0D1C.7080601@dlhnet.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: Peter Lieven , qemu-devel@nongnu.org Hi, >> I guess reset_keys() should skip capslock+numlock to not disturb the >> sync logic, can you try that? > > mhh, i might be wrong, but where could the vs->modifiers_state be not zero > on a new connection. I only find a g_malloc0 initializing the VNCState. Ah, right, it is in the per-connection vnc state not in the server-global vnc state. Yes, I guess we should store ledstate in VncDisplay then, so we can call kbd_leds() on new connections. cheers, Gerd