From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
peter.crosthwaite@xilinx.com,
Igor Mitsyanko <i.mitsyanko@gmail.com>,
sw@weilnetz.de, qemu-devel@nongnu.org, blauwirbel@gmail.com,
aliguori@us.ibm.com, stefanha@redhat.com, afaerber@suse.de,
paul@codesourcery.com
Subject: Re: [Qemu-devel] [RFC 2/7] sd.c: introduce variable for trekking valid data
Date: Mon, 17 Jun 2013 16:03:58 +0200 [thread overview]
Message-ID: <51BF174E.4050708@redhat.com> (raw)
In-Reply-To: <20130617123040.GA30145@stefanha-thinkpad.redhat.com>
Il 17/06/2013 14:30, Stefan Hajnoczi ha scritto:
>>> > > @@ -116,6 +116,7 @@ struct SDState {
>>> > > QEMUIOVector qiov;
>>> > > struct iovec iov;
>>> > > BlockDriverAIOCB *aiocb;
>>> > > + uint32_t transf_cnt;
>> >
>> > How does this work for migration -- are we guaranteed that
>> > all outstanding AIO requests complete before we try to
>> > migrate?
> Migration does bdrv_drain_all() to complete all pending requests
> (indirectly by pausing the guest in do_vm_stop()).
... and sd.c AFAIR doesn't support rerror/werror so it doesn't have to
migrate pending requests.
Paolo
next prev parent reply other threads:[~2013-06-17 14:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 16:10 [Qemu-devel] [RFC 0/7] Convert SD card model to AIO Igor Mitsyanko
2013-05-10 16:10 ` [Qemu-devel] [RFC 1/7] sd.c: introduce AIO related members in SD state Igor Mitsyanko
2013-05-10 16:10 ` [Qemu-devel] [RFC 2/7] sd.c: introduce variable for trekking valid data Igor Mitsyanko
2013-06-14 11:49 ` Peter Maydell
2013-06-17 12:30 ` Stefan Hajnoczi
2013-06-17 14:03 ` Paolo Bonzini [this message]
2013-05-10 16:10 ` [Qemu-devel] [RFC 3/7] sd.c: introduce "start bit" and "busy deasserted" callbacks Igor Mitsyanko
2013-06-14 11:51 ` Peter Maydell
2013-05-10 16:10 ` [Qemu-devel] [RFC 4/7] sd.c: use callbacks as a flag to use async IO Igor Mitsyanko
2013-05-10 16:10 ` [Qemu-devel] [RFC 5/7] sd.c: introduce async read operation Igor Mitsyanko
2013-05-13 12:10 ` Stefan Hajnoczi
2013-05-10 16:10 ` [Qemu-devel] [RFC 6/7] sd.c: introduce async write interface Igor Mitsyanko
2013-06-14 12:09 ` Peter Maydell
2013-05-10 16:10 ` [Qemu-devel] [RFC 7/7] pl181.c: convert to async IO SD card interface Igor Mitsyanko
2013-06-14 12:05 ` Peter Maydell
2013-05-13 12:13 ` [Qemu-devel] [RFC 0/7] Convert SD card model to AIO Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BF174E.4050708@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=i.mitsyanko@gmail.com \
--cc=paul@codesourcery.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).