From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35736)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Uoa2Z-0004GA-Un
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 10:04:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Uoa2U-0000pZ-U2
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 10:04:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13961)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Uoa2U-0000pJ-LX
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 10:04:10 -0400
Message-ID: <51BF174E.4050708@redhat.com>
Date: Mon, 17 Jun 2013 16:03:58 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1368202225-45798-1-git-send-email-i.mitsyanko@gmail.com>
	<1368202225-45798-3-git-send-email-i.mitsyanko@gmail.com>
	<CAFEAcA8J3c6MtjMsMpN77RTAnHmte9tSb54yCPQcfzt5m=zceg@mail.gmail.com>
	<20130617123040.GA30145@stefanha-thinkpad.redhat.com>
In-Reply-To: <20130617123040.GA30145@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 2/7] sd.c: introduce variable for trekking
 valid data
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, peter.crosthwaite@xilinx.com, Igor Mitsyanko <i.mitsyanko@gmail.com>, sw@weilnetz.de, qemu-devel@nongnu.org, blauwirbel@gmail.com, aliguori@us.ibm.com, stefanha@redhat.com, afaerber@suse.de, paul@codesourcery.com

Il 17/06/2013 14:30, Stefan Hajnoczi ha scritto:
>>> > > @@ -116,6 +116,7 @@ struct SDState {
>>> > >      QEMUIOVector qiov;
>>> > >      struct iovec iov;
>>> > >      BlockDriverAIOCB *aiocb;
>>> > > +    uint32_t transf_cnt;
>> > 
>> > How does this work for migration -- are we guaranteed that
>> > all outstanding AIO requests complete before we try to
>> > migrate?
> Migration does bdrv_drain_all() to complete all pending requests
> (indirectly by pausing the guest in do_vm_stop()).

... and sd.c AFAIR doesn't support rerror/werror so it doesn't have to
migrate pending requests.

Paolo