From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40977)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pl@dlhnet.de>) id 1UobVo-0007rX-LD
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 11:38:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@dlhnet.de>) id 1UobVi-0002wh-KN
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 11:38:32 -0400
Received: from ssl.dlhnet.de ([91.198.192.8]:54344 helo=ssl.dlh.net)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@dlhnet.de>)
	id 1UobVi-0002wW-ES
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 11:38:26 -0400
Message-ID: <51BF2D71.7060305@dlhnet.de>
Date: Mon, 17 Jun 2013 17:38:25 +0200
From: Peter Lieven <pl@dlhnet.de>
MIME-Version: 1.0
References: <1328704089-18691-1-git-send-email-kraxel@redhat.com>
	<77c7f18a4c427a64b1d16821b631e758.squirrel@ssl.dlhnet.de>
	<51BECD7E.4090305@redhat.com> <51BEED6D.7000008@dlhnet.de>
	<51BEFC62.6080109@redhat.com> <51BF0D1C.7080601@dlhnet.de>
	<51BF1620.1020608@redhat.com>
In-Reply-To: <51BF1620.1020608@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client
	disconnect.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Peter Lieven <lieven@dlhnet.de>, qemu-devel@nongnu.org

Am 17.06.2013 15:58, schrieb Gerd Hoffmann:
>   Hi,
> 
>>> I guess reset_keys() should skip capslock+numlock to not disturb the
>>> sync logic, can you try that?
>>
>> mhh, i might be wrong, but where could the vs->modifiers_state be not zero
>> on a new connection. I only find a g_malloc0 initializing the VNCState.
> 
> Ah, right, it is in the per-connection vnc state not in the
> server-global vnc state.  Yes, I guess we should store ledstate in
> VncDisplay then, so we can call kbd_leds() on new connections.

maybe all modifiers should be stored global?

anyway, what also seems to work is to clear capslock / numlock on disconnect
like shift,alt,ctrl if the sync logic is enabled.

Peter

> 
> cheers,
>   Gerd
> 
>