From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36787)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uog8a-00074c-Fj
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 16:34:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uog8X-0003OE-Vs
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 16:34:52 -0400
Received: from mail-ye0-f172.google.com ([209.85.213.172]:61267)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uog8X-0003OA-Re
	for qemu-devel@nongnu.org; Mon, 17 Jun 2013 16:34:49 -0400
Received: by mail-ye0-f172.google.com with SMTP id l13so1079446yen.31
	for <qemu-devel@nongnu.org>; Mon, 17 Jun 2013 13:34:49 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51BF72E5.5070003@twiddle.net>
Date: Mon, 17 Jun 2013 13:34:45 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1371398269-6213-1-git-send-email-afaerber@suse.de>
	<1371398269-6213-19-git-send-email-afaerber@suse.de>
In-Reply-To: <1371398269-6213-19-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH qom-cpu v2 18/29] cpu: Turn
 cpu_unassigned_access() into a CPUState hook
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org

On 06/16/2013 08:57 AM, Andreas Färber wrote:
> +        cpu = CPU(alpha_env_get_cpu(cpu_single_env));
> +        cs = CPU(alpha_env_get_cpu(cpu_single_env));
> +    CPUState *cpu_single_cpu = CPU(alpha_env_get_cpu(cpu_single_env));
> +        cs = CPU(alpha_env_get_cpu(cpu_single_env));

ENV_GET_CPU.

> +    cpu_class_set_do_unassigned_access(cc, alpha_cpu_unassigned_access);

Wouldn't it be better to arrange for the function to exist always, with
differing implementation for user and system, much like do_interrupt?

What you've got is good enough for now, I suppose.


r~