From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UohbB-0001es-4l for qemu-devel@nongnu.org; Mon, 17 Jun 2013 18:08:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UohbA-0007Pi-19 for qemu-devel@nongnu.org; Mon, 17 Jun 2013 18:08:29 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34906 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uohb9-0007Pc-R6 for qemu-devel@nongnu.org; Mon, 17 Jun 2013 18:08:27 -0400 Message-ID: <51BF88D9.5080905@suse.de> Date: Tue, 18 Jun 2013 00:08:25 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1370453368-21214-1-git-send-email-rth@twiddle.net> <1370453368-21214-4-git-send-email-rth@twiddle.net> In-Reply-To: <1370453368-21214-4-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 3/4] tcg-i386: Use QEMU_BUILD_BUG_ON instead of assert for frame size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, aurelien@aurel32.net Am 05.06.2013 19:29, schrieb Richard Henderson: > We can check the condition at compile time, rather than run time. >=20 > Signed-off-by: Richard Henderson > --- > tcg/i386/tcg-target.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c > index 7d946eb..991f484 100644 > --- a/tcg/i386/tcg-target.c > +++ b/tcg/i386/tcg-target.c > @@ -2324,6 +2324,9 @@ typedef struct { > uint8_t fde_reg_ofs[14]; > } DebugFrame; > =20 > +/* We're expecting a 2 byte uleb128 encoded value. */ > +QEMU_BUILD_BUG_ON(FRAME_SIZE >=3D (1 << 14)); Reviewed-by: Andreas F=E4rber Andreas > + > #if !defined(__ELF__) > /* Host machine without ELF. */ > #elif TCG_TARGET_REG_BITS =3D=3D 64 > @@ -2387,9 +2390,6 @@ static DebugFrame debug_frame =3D { > #if defined(ELF_HOST_MACHINE) > void tcg_register_jit(void *buf, size_t buf_size) > { > - /* We're expecting a 2 byte uleb128 encoded value. */ > - assert(FRAME_SIZE >> 14 =3D=3D 0); > - > debug_frame.fde.func_start =3D (tcg_target_long) buf; > debug_frame.fde.func_len =3D buf_size; > =20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg