From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uop27-0008SE-HQ for qemu-devel@nongnu.org; Tue, 18 Jun 2013 02:04:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uop26-0002k3-Is for qemu-devel@nongnu.org; Tue, 18 Jun 2013 02:04:47 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:33411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uop25-0002jO-IN for qemu-devel@nongnu.org; Tue, 18 Jun 2013 02:04:46 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 18 Jun 2013 15:57:38 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 0157A2CE8044 for ; Tue, 18 Jun 2013 16:04:40 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5I5nnAt35061788 for ; Tue, 18 Jun 2013 15:49:50 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5I64dN6025422 for ; Tue, 18 Jun 2013 16:04:39 +1000 Message-ID: <51BFF83C.4050909@linux.vnet.ibm.com> Date: Tue, 18 Jun 2013 14:03:40 +0800 From: Lei Li MIME-Version: 1.0 References: <1371397053-4503-1-git-send-email-lilei@linux.vnet.ibm.com> <1371397053-4503-2-git-send-email-lilei@linux.vnet.ibm.com> <87ehc2hwnc.fsf@codemonkey.ws> In-Reply-To: <87ehc2hwnc.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/7] migration: export MIG_STATE_xxx flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: lagarcia@br.ibm.com, qemu-devel@nongnu.org, quintela@redhat.com On 06/17/2013 12:01 AM, Anthony Liguori wrote: > Lei Li writes: > >> Signed-off-by: Lei Li >> --- >> include/migration/migration.h | 8 ++++++++ >> migration.c | 8 -------- >> 2 files changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/include/migration/migration.h b/include/migration/migration.h >> index e2acec6..8866c3c 100644 >> --- a/include/migration/migration.h >> +++ b/include/migration/migration.h >> @@ -22,6 +22,14 @@ >> #include "migration/vmstate.h" >> #include "qapi-types.h" >> >> +enum { >> + MIG_STATE_ERROR, >> + MIG_STATE_SETUP, >> + MIG_STATE_CANCELLED, >> + MIG_STATE_ACTIVE, >> + MIG_STATE_COMPLETED, >> +}; >> + > If these flags are being exported, it would be nice to provide comments > describing what each state corresponded to. Got it, thanks. > > Regards, > > Anthony Liguori > >> struct MigrationParams { >> bool blk; >> bool shared; >> diff --git a/migration.c b/migration.c >> index 058f9e6..0921ace 100644 >> --- a/migration.c >> +++ b/migration.c >> @@ -35,14 +35,6 @@ >> do { } while (0) >> #endif >> >> -enum { >> - MIG_STATE_ERROR, >> - MIG_STATE_SETUP, >> - MIG_STATE_CANCELLED, >> - MIG_STATE_ACTIVE, >> - MIG_STATE_COMPLETED, >> -}; >> - >> #define MAX_THROTTLE (32 << 20) /* Migration speed throttling */ >> >> /* Amount of time to allocate to each "chunk" of bandwidth-throttled >> -- >> 1.7.7.6 -- Lei