From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uop49-0000vZ-UW for qemu-devel@nongnu.org; Tue, 18 Jun 2013 02:06:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uop48-0003YD-SV for qemu-devel@nongnu.org; Tue, 18 Jun 2013 02:06:53 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:54724) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uop48-0003Xz-1M for qemu-devel@nongnu.org; Tue, 18 Jun 2013 02:06:52 -0400 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 18 Jun 2013 16:04:06 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 31D782CE804D for ; Tue, 18 Jun 2013 16:06:46 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5I66bQv65404968 for ; Tue, 18 Jun 2013 16:06:37 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5I66jXr007191 for ; Tue, 18 Jun 2013 16:06:45 +1000 Message-ID: <51BFF8BA.90001@linux.vnet.ibm.com> Date: Tue, 18 Jun 2013 14:05:46 +0800 From: Lei Li MIME-Version: 1.0 References: <1371397053-4503-1-git-send-email-lilei@linux.vnet.ibm.com> <1371397053-4503-3-git-send-email-lilei@linux.vnet.ibm.com> <87bo76hwly.fsf@codemonkey.ws> In-Reply-To: <87bo76hwly.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/7] savevm: export qemu_save_device_state() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: lagarcia@br.ibm.com, qemu-devel@nongnu.org, quintela@redhat.com On 06/17/2013 12:02 AM, Anthony Liguori wrote: > Lei Li writes: > >> Signed-off-by: Lei Li >> --- >> include/sysemu/sysemu.h | 1 + >> savevm.c | 2 +- >> 2 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h >> index 2fb71af..5b90027 100644 >> --- a/include/sysemu/sysemu.h >> +++ b/include/sysemu/sysemu.h >> @@ -80,6 +80,7 @@ int qemu_savevm_state_iterate(QEMUFile *f); >> void qemu_savevm_state_complete(QEMUFile *f); >> void qemu_savevm_state_cancel(void); >> uint64_t qemu_savevm_state_pending(QEMUFile *f, uint64_t max_size); >> +int qemu_save_device_state(QEMUFile *f); >> int qemu_loadvm_state(QEMUFile *f); > Please add comments describing what this function does. I know they're > absent for the rest of the functions but we have to start somewhere. OK, will do. > > Regards, > > Anthony Liguori > >> >> /* SLIRP */ >> diff --git a/savevm.c b/savevm.c >> index 2ce439f..e3ad5da 100644 >> --- a/savevm.c >> +++ b/savevm.c >> @@ -2006,7 +2006,7 @@ static int qemu_savevm_state(QEMUFile *f) >> return ret; >> } >> >> -static int qemu_save_device_state(QEMUFile *f) >> +int qemu_save_device_state(QEMUFile *f) >> { >> SaveStateEntry *se; >> >> -- >> 1.7.7.6 -- Lei