From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
stefanha@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: add 'backing' option to drive_add
Date: Tue, 18 Jun 2013 11:11:21 +0200 [thread overview]
Message-ID: <51C02439.10805@redhat.com> (raw)
In-Reply-To: <20130618085620.GE3640@dhcp-200-207.str.redhat.com>
Il 18/06/2013 10:56, Kevin Wolf ha scritto:
>> >
>> > It is a huge swamp indeed.
>> >
>> > Since we stop all block jobs on media change already, what about just
>> > adding a command "block-job-attach" or something like that which exposes
>> > the target of the job as a blockdev (presumably so that you can then add
>> > it to the NBD server)?
> This is backwards. You should really give the block job a target BDS to
> begin with, not a file name.
That's also ok... We can get the backing file right for the target BDS
at the beginning of the backup job with a combination of
close_unused_images (so that it is "as if" block-backup had opened the
file with BDRV_O_NO_BACKING), bdrv_append and bdrv_swap (append the
target to the VM's BDS, swap the two).
So why do we need this new option to drive_add? The "drive"
ImageCreationMode, for which Fam has a patch too, should do.
Paolo
next prev parent reply other threads:[~2013-06-18 9:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1371457366-10993-1-git-send-email-famz@redhat.com>
[not found] ` <51BED513.3030800@redhat.com>
[not found] ` <20130617093241.GA22609@localhost.nay.redhat.com>
[not found] ` <51BEDCB9.5090905@redhat.com>
[not found] ` <20130617135253.GB3994@dhcp-200-207.str.redhat.com>
[not found] ` <51BF16B8.6040801@redhat.com>
[not found] ` <20130617142605.GD3994@dhcp-200-207.str.redhat.com>
[not found] ` <51BF213F.60601@redhat.com>
[not found] ` <20130617151238.GF3994@dhcp-200-207.str.redhat.com>
2013-06-18 3:58 ` [Qemu-devel] [PATCH] block: add 'backing' option to drive_add Fam Zheng
2013-06-18 6:32 ` Kevin Wolf
2013-06-18 7:00 ` Fam Zheng
2013-06-18 7:51 ` Kevin Wolf
2013-06-18 8:11 ` Fam Zheng
2013-06-18 8:52 ` Kevin Wolf
2013-06-18 14:18 ` Markus Armbruster
2013-06-19 1:17 ` Fam Zheng
2013-06-19 6:27 ` Markus Armbruster
2013-06-19 7:08 ` Fam Zheng
2013-06-18 6:37 ` Markus Armbruster
2013-06-18 7:06 ` Fam Zheng
2013-06-18 8:40 ` Paolo Bonzini
2013-06-18 8:56 ` Kevin Wolf
2013-06-18 9:11 ` Paolo Bonzini [this message]
2013-06-18 9:12 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C02439.10805@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).