From: Paolo Bonzini <pbonzini@redhat.com>
To: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Cc: libaiqing@huawei.com, mdroth@linux.vnet.ibm.com,
stefanha@gmail.com, qemu-devel@nongnu.org,
lcapitulino@redhat.com, vrozenfe@redhat.com,
seiji.aguchi@hds.com, areis@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 10/10] QMP/qemu-ga-client: make timeout longer for guest-fsfreeze-freeze command
Date: Tue, 18 Jun 2013 12:17:37 +0200 [thread overview]
Message-ID: <51C033C1.7080406@redhat.com> (raw)
In-Reply-To: <20130606150702.10486.89130.stgit@hds.com>
Il 06/06/2013 17:07, Tomoki Sekiyama ha scritto:
> guest-fsfreeze-freeze command can take longer than 3 seconds when heavy
> disk I/O is running. To avoid unexpected timeout, this changes the timeout
> to 60 seconds (timeout of pre-commit phase of VSS).
>
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
> ---
> QMP/qemu-ga-client | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/QMP/qemu-ga-client b/QMP/qemu-ga-client
> index 46676c3..b5f7e7c 100755
> --- a/QMP/qemu-ga-client
> +++ b/QMP/qemu-ga-client
> @@ -267,7 +267,9 @@ def main(address, cmd, args):
> print('Hint: qemu is not running?')
> sys.exit(1)
>
> - if cmd != 'ping':
> + if cmd == 'fsfreeze' and args[0] == 'freeze':
> + client.sync(60)
> + elif cmd != 'ping':
> client.sync()
>
> globals()['_cmd_' + cmd](client, args)
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2013-06-18 10:18 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 15:06 [Qemu-devel] [PATCH v4 00/10] qemu-ga: fsfreeze on Windows using VSS Tomoki Sekiyama
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 01/10] configure: Support configuring c++ compiler Tomoki Sekiyama
2013-06-18 10:17 ` Paolo Bonzini
2013-06-25 8:15 ` Laszlo Ersek
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 02/10] Add c++ keywords to QAPI helper script Tomoki Sekiyama
2013-06-25 8:16 ` Laszlo Ersek
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 03/10] checkpatch.pl: check .cpp files Tomoki Sekiyama
2013-06-25 8:17 ` Laszlo Ersek
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 04/10] Add a script to extract VSS SDK headers on POSIX system Tomoki Sekiyama
2013-06-25 8:30 ` Laszlo Ersek
2013-06-25 15:01 ` Laszlo Ersek
2013-06-25 15:01 ` Paolo Bonzini
2013-06-26 10:52 ` Laszlo Ersek
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 05/10] qemu-ga: Add configure options to specify path to Windows/VSS SDK Tomoki Sekiyama
2013-06-25 11:16 ` Laszlo Ersek
2013-06-28 10:43 ` Daniel P. Berrange
2013-06-28 10:54 ` Paolo Bonzini
2013-06-28 11:01 ` Daniel P. Berrange
2013-06-28 11:18 ` Paolo Bonzini
2013-06-28 11:30 ` Daniel P. Berrange
2013-06-28 12:18 ` Paolo Bonzini
2013-06-28 11:05 ` Laszlo Ersek
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 06/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze Tomoki Sekiyama
2013-06-25 16:03 ` Laszlo Ersek
2013-06-25 16:19 ` Paolo Bonzini
2013-06-25 18:23 ` Tomoki Sekiyama
2013-06-25 18:59 ` Paolo Bonzini
2013-06-25 19:28 ` Tomoki Sekiyama
2013-06-25 19:52 ` Laszlo Ersek
2013-06-26 14:32 ` Laszlo Ersek
2013-06-26 21:27 ` Paolo Bonzini
2013-06-26 22:09 ` Tomoki Sekiyama
2013-06-27 15:01 ` Laszlo Ersek
2013-06-27 22:25 ` Tomoki Sekiyama
2013-06-28 7:05 ` Paolo Bonzini
2013-06-28 10:40 ` Laszlo Ersek
2013-06-28 10:40 ` Paolo Bonzini
2013-06-28 17:18 ` Tomoki Sekiyama
2013-06-28 10:44 ` Laszlo Ersek
2013-06-25 21:15 ` Paolo Bonzini
2013-06-25 22:31 ` Tomoki Sekiyama
2013-06-26 5:59 ` Paolo Bonzini
2013-06-26 14:13 ` Tomoki Sekiyama
2013-06-30 13:16 ` Gal Hammer
2013-07-01 18:57 ` Tomoki Sekiyama
2013-07-02 12:36 ` Gal Hammer
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 07/10] qemu-ga: Add Windows VSS requester to quiesce applications and filesystems Tomoki Sekiyama
2013-06-28 18:01 ` Laszlo Ersek
2013-06-28 18:34 ` Laszlo Ersek
2013-06-30 1:21 ` Tomoki Sekiyama
2013-07-01 8:31 ` Laszlo Ersek
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 08/10] qemu-ga: call Windows VSS requester in fsfreeze command handler Tomoki Sekiyama
2013-07-01 13:29 ` Laszlo Ersek
2013-07-01 17:48 ` Eric Blake
2013-07-01 17:59 ` Tomoki Sekiyama
2013-07-02 6:36 ` Laszlo Ersek
2013-07-02 14:09 ` Luiz Capitulino
2013-07-02 14:44 ` Laszlo Ersek
2013-07-02 15:16 ` Luiz Capitulino
2013-07-02 15:28 ` Laszlo Ersek
2013-07-02 14:58 ` Michael Roth
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 09/10] qemu-ga: install Windows VSS provider on `qemu-ga -s install' Tomoki Sekiyama
2013-07-01 14:50 ` Laszlo Ersek
2013-07-01 17:59 ` Tomoki Sekiyama
2013-06-06 15:07 ` [Qemu-devel] [PATCH v4 10/10] QMP/qemu-ga-client: make timeout longer for guest-fsfreeze-freeze command Tomoki Sekiyama
2013-06-18 10:17 ` Paolo Bonzini [this message]
2013-07-01 15:02 ` Laszlo Ersek
2013-06-10 9:26 ` [Qemu-devel] [PATCH v4 00/10] qemu-ga: fsfreeze on Windows using VSS Stefan Hajnoczi
2013-06-24 19:30 ` Tomoki Sekiyama
2013-06-24 21:13 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C033C1.7080406@redhat.com \
--to=pbonzini@redhat.com \
--cc=areis@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=libaiqing@huawei.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=seiji.aguchi@hds.com \
--cc=stefanha@gmail.com \
--cc=tomoki.sekiyama@hds.com \
--cc=vrozenfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).