From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49600)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Uovtp-0003vv-Rl
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 09:24:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Uovto-0001CW-NI
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 09:24:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:14975)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Uovto-0001CP-Fo
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 09:24:40 -0400
Message-ID: <51C05F91.6020201@redhat.com>
Date: Tue, 18 Jun 2013 15:24:33 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1371477707-7039-1-git-send-email-kraxel@redhat.com>
	<1371477707-7039-3-git-send-email-kraxel@redhat.com>
	<87a9mo4x38.fsf@codemonkey.ws> <20130617105018.26c2eadc@redhat.com>
	<51C02766.5020301@redhat.com> <20130618091323.26c2988b@redhat.com>
In-Reply-To: <20130618091323.26c2988b@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp
 cmd
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, alevy@redhat.com, stefanha@redhat.com

  Hi,

>> Something like the attached patch?  Which is just the bare minimum I'll
>> need for screendump.  Basically a one-off bottom half with some monitor
>> infrastructure (job id, error handling).  So it isn't for big jobs, but
>> for small jobs which have to wait for something before they execute
>> (spice-server, guest action, whatever).
> 
> I only skimmed over the patch, but you need QMP commands to cancel
> and to query running jobs.

Sure, can easily go on top, just need to stuff the monitor_jobs into a
list and allow ops on it.  Just want to make sure the direction I'm
heading to is fine.

> Also, please move all this stuff to qmp.c
> and do s/monitor/qmp rename.

Will do.

> Lastly, is it possible to have the block job QMP API on top of this
> new QMP job API?

Don't think so.  As mentioned above this does short-running jobs as
bottom half whereas block jobs are running in coroutines ...

cheers,
  Gerd