From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51021)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Uow0V-0000KJ-4p
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 09:31:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Uow0M-0003Bb-EC
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 09:31:35 -0400
Received: from goliath.siemens.de ([192.35.17.28]:29525)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Uow0M-0003BI-5H
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 09:31:26 -0400
Message-ID: <51C06129.8060802@siemens.com>
Date: Tue, 18 Jun 2013 15:31:21 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1370265109-8753-1-git-send-email-bas@quarantainenet.nl>
	<20130604122614.GC10055@stefanha-thinkpad.redhat.com>
	<51BEF5F4.5090309@quarantainenet.nl>
In-Reply-To: <51BEF5F4.5090309@quarantainenet.nl>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] [slirp] fix -net user checks by reordering
 checks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bas van Sisseren <bas@quarantainenet.nl>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Qemu-devel <qemu-devel@nongnu.org>

On 2013-06-17 13:41, Bas van Sisseren wrote:
> On 04/06/13 14:26, Stefan Hajnoczi wrote:
>> On Mon, Jun 03, 2013 at 03:11:49PM +0200, Bas van Sisseren wrote:
>>> reorder slirp config options. first check the dns-server-address,
>>> then check the first-dhcp-address. the original code was comparing
>>> the first-dhcp-address with the default dns-server-address, not
>>> the configured dns-server-address.
>>>
>>> Signed-off-by: Bas van Sisseren <bas@quarantainenet.nl>
>>> ---
>>>  net/slirp.c |   12 ++++++------
>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
> Hello qemu-devel list,
> 
> The last reaction was 2 weeks ago. Do I need more reviews for inclusion of
> the patch?
> 

Nope, thanks, just applied to my slirp queue.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux