From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] hw/scsi: Don't increment a boolean value
Date: Tue, 18 Jun 2013 16:14:33 +0200 [thread overview]
Message-ID: <51C06B49.9030405@redhat.com> (raw)
In-Reply-To: <1370895896-10546-1-git-send-email-sw@weilnetz.de>
Il 10/06/2013 22:24, Stefan Weil ha scritto:
> This fixes a warning from cppcheck.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/scsi/vmw_pvscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
> index 48d12f4..446f723 100644
> --- a/hw/scsi/vmw_pvscsi.c
> +++ b/hw/scsi/vmw_pvscsi.c
> @@ -389,7 +389,7 @@ pvscsi_process_completion_queue(void *opaque)
> QTAILQ_REMOVE(&s->completion_queue, pvscsi_req, next);
> pvscsi_cmp_ring_put(s, &pvscsi_req->cmp);
> g_free(pvscsi_req);
> - has_completed++;
> + has_completed = true;
> }
>
> if (has_completed) {
>
Applied to scsi-next branch, thanks.
Paolo
prev parent reply other threads:[~2013-06-18 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 20:24 [Qemu-devel] [PATCH] hw/scsi: Don't increment a boolean value Stefan Weil
2013-06-18 14:14 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C06B49.9030405@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).