* [Qemu-devel] [PATCH] hw/scsi: Don't increment a boolean value
@ 2013-06-10 20:24 Stefan Weil
2013-06-18 14:14 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2013-06-10 20:24 UTC (permalink / raw)
To: qemu-trivial; +Cc: Paolo Bonzini, qemu-devel, Stefan Weil
This fixes a warning from cppcheck.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/scsi/vmw_pvscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
index 48d12f4..446f723 100644
--- a/hw/scsi/vmw_pvscsi.c
+++ b/hw/scsi/vmw_pvscsi.c
@@ -389,7 +389,7 @@ pvscsi_process_completion_queue(void *opaque)
QTAILQ_REMOVE(&s->completion_queue, pvscsi_req, next);
pvscsi_cmp_ring_put(s, &pvscsi_req->cmp);
g_free(pvscsi_req);
- has_completed++;
+ has_completed = true;
}
if (has_completed) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/scsi: Don't increment a boolean value
2013-06-10 20:24 [Qemu-devel] [PATCH] hw/scsi: Don't increment a boolean value Stefan Weil
@ 2013-06-18 14:14 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2013-06-18 14:14 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
Il 10/06/2013 22:24, Stefan Weil ha scritto:
> This fixes a warning from cppcheck.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/scsi/vmw_pvscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
> index 48d12f4..446f723 100644
> --- a/hw/scsi/vmw_pvscsi.c
> +++ b/hw/scsi/vmw_pvscsi.c
> @@ -389,7 +389,7 @@ pvscsi_process_completion_queue(void *opaque)
> QTAILQ_REMOVE(&s->completion_queue, pvscsi_req, next);
> pvscsi_cmp_ring_put(s, &pvscsi_req->cmp);
> g_free(pvscsi_req);
> - has_completed++;
> + has_completed = true;
> }
>
> if (has_completed) {
>
Applied to scsi-next branch, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-18 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-10 20:24 [Qemu-devel] [PATCH] hw/scsi: Don't increment a boolean value Stefan Weil
2013-06-18 14:14 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).