From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpEHA-0004nv-Ai for qemu-devel@nongnu.org; Wed, 19 Jun 2013 05:02:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpEH9-00008j-6N for qemu-devel@nongnu.org; Wed, 19 Jun 2013 05:02:00 -0400 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:36309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpEH8-000083-HV for qemu-devel@nongnu.org; Wed, 19 Jun 2013 05:01:59 -0400 Received: from /spool/local by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 19 Jun 2013 14:27:25 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 64AB1E0054 for ; Wed, 19 Jun 2013 14:31:18 +0530 (IST) Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5J921og14483514 for ; Wed, 19 Jun 2013 14:32:01 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5J91n1a011231 for ; Wed, 19 Jun 2013 19:01:51 +1000 Message-ID: <51C1736F.9070401@linux.vnet.ibm.com> Date: Wed, 19 Jun 2013 17:01:35 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1371209999-15579-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1371209999-15579-13-git-send-email-xiawenc@linux.vnet.ibm.com> <20130618143212.GP7649@stefanha-thinkpad.redhat.com> <51C14DEB.4050702@linux.vnet.ibm.com> <20130619074649.GD23822@stefanha-thinkpad.muc.redhat.com> In-Reply-To: <20130619074649.GD23822@stefanha-thinkpad.muc.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V2 12/12] qemu-iotests: add 055 internal snapshot for block device test case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, phrdina@redhat.com, famz@redhat.com, Stefan Hajnoczi , armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com, dietmar@proxmox.com > On Wed, Jun 19, 2013 at 02:21:31PM +0800, Wenchao Xia wrote: >> 于 2013-6-18 22:32, Stefan Hajnoczi 写道: >>> On Fri, Jun 14, 2013 at 07:39:59PM +0800, Wenchao Xia wrote: >>>> + def createSnapshotInTransaction(self, snapshot_num): >>>> + actions = [] >>>> + for i in range(0, len(self.expect)): >>>> + num = self.expect[i]['snapshots_name_counter'] >>>> + for j in range(0, snapshot_num): >>>> + name = '%s_sn%d' % (self.expect[i]['device'], num) >>>> + num = num + 1 >>>> + self.expect[i]['snapshots'].append(name) >>>> + actions.append({ >>>> + 'type': 'blockdev-snapshot-internal-sync', >>>> + 'data': { 'device': self.expect[i]['device'], >>>> + 'name': name }, >>>> + }) >>>> + self.expect[i]['snapshots_name_counter'] = num >>>> + result = self.vm.qmp('transaction', actions = actions) >>>> + self.assert_qmp(result, 'return', {}) >>> >>> This tests the success case. Please also use the 'Abort' action to test >>> the error case. >> Is "Abort" upstreamed? If yes I will add that part. > > It's part of the drive-backup series which you have already > cherry-picked from. > Will you continue work on drive-backup? I'd like to rebase this serial after your v6, to reduce conflict. -- Best Regards Wenchao Xia