From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpGRM-0007FW-4v for qemu-devel@nongnu.org; Wed, 19 Jun 2013 07:20:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpGRG-0002ca-HX for qemu-devel@nongnu.org; Wed, 19 Jun 2013 07:20:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36676) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpGRG-0002cL-Ay for qemu-devel@nongnu.org; Wed, 19 Jun 2013 07:20:34 -0400 Message-ID: <51C193C6.8010906@redhat.com> Date: Wed, 19 Jun 2013 13:19:34 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1369917299-5725-1-git-send-email-stefanha@redhat.com> <1369917299-5725-4-git-send-email-stefanha@redhat.com> <20130619105015.GA2934@dhcp-200-207.str.redhat.com> In-Reply-To: <20130619105015.GA2934@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Fam Zheng , qemu-devel@nongnu.org, dietmar@proxmox.com, imain@redhat.com, Stefan Hajnoczi , xiawenc@linux.vnet.ibm.com Il 19/06/2013 12:50, Kevin Wolf ha scritto: >> > + >> > + DPRINTF("%s enter %s C%" PRId64 " %" PRId64 " %d\n", >> > + __func__, bdrv_get_device_name(bs), start, sector_num, nb_sectors); > Maybe put the first "%s" and __func__ directly into the DPRINTF macro? > Or just use tracepoints. backup_do_cow could definitely be one, and it would subsume another DPRINTF ("backup_run loop"). hbitmap_get and block_job_completed are two other useful tracepoint that is not present. All that's left then are the DPRINTF for failed readv and writev, which could also be useful in generic code (bdrv_co_*_done). Can be done as a follow-up, of course. Paolo