Re: [Qemu-devel] [PATCH v4 1/9] dump: Add API to manipulate dump_bitmap

["Andreas Färber" <afaerber@suse.de>]

Am 28.05.2013 04:50, schrieb qiaonuohan@cn.fujitsu.com:
> From: Qiao Nuohan <qiaonuohan@cn.fujitsu.com>
> 
> Struct dump_bitmap is associated with a tmp file which is used to store bitmap
> in kdump-compressed format temporarily. The following patch will use these
> functions to gather data of bitmap and cache them into tmp files.
> 
> Signed-off-by: Qiao Nuohan <qiaonuohan@cn.fujitsu.com>
> Reviewed-by: Zhang Xiaohe <zhangxh@cn.fujitsu.com>
> ---
>  Makefile.target       |    1 +
>  dump_bitmap.c         |  171 +++++++++++++++++++++++++++++++++++++++++++++++++
>  include/dump_bitmap.h |   60 +++++++++++++++++
>  3 files changed, 232 insertions(+), 0 deletions(-)
>  create mode 100644 dump_bitmap.c
>  create mode 100644 include/dump_bitmap.h

As expected only applied with --3way now.

Build fails as follows:

  CC    alpha-softmmu/dump_bitmap.o
/home/andreas/QEMU/qemu/dump_bitmap.c: In function ‘is_bit_set’:
/home/andreas/QEMU/qemu/dump_bitmap.c:155:13: error: ignoring return
value of ‘read’, declared with attribute warn_unused_result
[-Werror=unused-result]
cc1: all warnings being treated as errors
make[1]: *** [dump_bitmap.o] Fehler 1
make: *** [subdir-alpha-softmmu] Fehler 2

That brings up another question: Why compile this file per target in
Makefile.target:obj-y rather than once in Makefile.objs:common-obj-y?
I don't see any target page sizes or target types being used.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg