From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpHCm-0008C2-Vo for qemu-devel@nongnu.org; Wed, 19 Jun 2013 08:09:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpHCl-0001ts-2F for qemu-devel@nongnu.org; Wed, 19 Jun 2013 08:09:40 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33464 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpH4M-0007iZ-Kk for qemu-devel@nongnu.org; Wed, 19 Jun 2013 08:00:58 -0400 Message-ID: <51C19D78.4030106@suse.de> Date: Wed, 19 Jun 2013 14:00:56 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1369709437-24969-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1369709437-24969-2-git-send-email-qiaonuohan@cn.fujitsu.com> In-Reply-To: <1369709437-24969-2-git-send-email-qiaonuohan@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 1/9] dump: Add API to manipulate dump_bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qiaonuohan@cn.fujitsu.com Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com, zhangxh@cn.fujitsu.com, kumagai-atsushi@mxc.nes.nec.co.jp, anderson@redhat.com Am 28.05.2013 04:50, schrieb qiaonuohan@cn.fujitsu.com: > From: Qiao Nuohan >=20 > Struct dump_bitmap is associated with a tmp file which is used to store= bitmap > in kdump-compressed format temporarily. The following patch will use th= ese > functions to gather data of bitmap and cache them into tmp files. >=20 > Signed-off-by: Qiao Nuohan > Reviewed-by: Zhang Xiaohe > --- > Makefile.target | 1 + > dump_bitmap.c | 171 +++++++++++++++++++++++++++++++++++++++++= ++++++++ > include/dump_bitmap.h | 60 +++++++++++++++++ > 3 files changed, 232 insertions(+), 0 deletions(-) > create mode 100644 dump_bitmap.c > create mode 100644 include/dump_bitmap.h As expected only applied with --3way now. Build fails as follows: CC alpha-softmmu/dump_bitmap.o /home/andreas/QEMU/qemu/dump_bitmap.c: In function =E2=80=98is_bit_set=E2= =80=99: /home/andreas/QEMU/qemu/dump_bitmap.c:155:13: error: ignoring return value of =E2=80=98read=E2=80=99, declared with attribute warn_unused_resu= lt [-Werror=3Dunused-result] cc1: all warnings being treated as errors make[1]: *** [dump_bitmap.o] Fehler 1 make: *** [subdir-alpha-softmmu] Fehler 2 That brings up another question: Why compile this file per target in Makefile.target:obj-y rather than once in Makefile.objs:common-obj-y? I don't see any target page sizes or target types being used. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg