From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpI4O-0007gS-AU for qemu-devel@nongnu.org; Wed, 19 Jun 2013 09:05:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpI4J-00048E-GU for qemu-devel@nongnu.org; Wed, 19 Jun 2013 09:05:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpI4J-00048A-8F for qemu-devel@nongnu.org; Wed, 19 Jun 2013 09:04:59 -0400 Message-ID: <51C1AC72.4060701@redhat.com> Date: Wed, 19 Jun 2013 15:04:50 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1371611919-5544-1-git-send-email-gaowanlong@cn.fujitsu.com> In-Reply-To: <1371611919-5544-1-git-send-email-gaowanlong@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH resend] pci-assign: remove the duplicate function name in debug message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wanlong Gao Cc: qemu-devel@nongnu.org Il 19/06/2013 05:18, Wanlong Gao ha scritto: > While DEBUG() already includes the function name. > > Signed-off-by: Wanlong Gao > Acked-by: Alex Williamson > --- > hw/i386/kvm/pci-assign.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c > index ff85590..9896c28 100644 > --- a/hw/i386/kvm/pci-assign.c > +++ b/hw/i386/kvm/pci-assign.c > @@ -226,7 +226,7 @@ static uint32_t slow_bar_readb(void *opaque, hwaddr addr) > uint32_t r; > > r = *in; > - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); > + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); > > return r; > } > @@ -238,7 +238,7 @@ static uint32_t slow_bar_readw(void *opaque, hwaddr addr) > uint32_t r; > > r = *in; > - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); > + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); > > return r; > } > @@ -250,7 +250,7 @@ static uint32_t slow_bar_readl(void *opaque, hwaddr addr) > uint32_t r; > > r = *in; > - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); > + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); > > return r; > } > @@ -260,7 +260,7 @@ static void slow_bar_writeb(void *opaque, hwaddr addr, uint32_t val) > AssignedDevRegion *d = opaque; > uint8_t *out = d->u.r_virtbase + addr; > > - DEBUG("slow_bar_writeb addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr, val); > + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr, val); > *out = val; > } > > @@ -269,7 +269,7 @@ static void slow_bar_writew(void *opaque, hwaddr addr, uint32_t val) > AssignedDevRegion *d = opaque; > uint16_t *out = (uint16_t *)(d->u.r_virtbase + addr); > > - DEBUG("slow_bar_writew addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr, val); > + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr, val); > *out = val; > } > > @@ -278,7 +278,7 @@ static void slow_bar_writel(void *opaque, hwaddr addr, uint32_t val) > AssignedDevRegion *d = opaque; > uint32_t *out = (uint32_t *)(d->u.r_virtbase + addr); > > - DEBUG("slow_bar_writel addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, val); > + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, val); > *out = val; > } > > Applied to uq/master, thanks. Paolo