From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpJ0c-00016b-Fn for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:05:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpJ0Z-0007UQ-IQ for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:05:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpJ0Z-0007UD-B8 for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:05:11 -0400 Message-ID: <51C1BB1F.3000305@redhat.com> Date: Wed, 19 Jun 2013 16:07:27 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1371560351-29057-1-git-send-email-mst@redhat.com> In-Reply-To: <1371560351-29057-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] pvpanic: initialization cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Hu Tao , Anthony Liguori , qemu-devel@nongnu.org, Markus Armbruster On 06/18/13 15:01, Michael S. Tsirkin wrote: > Avoid use of static variables: PC systems > initialize pvpanic device through pvpanic_init, > so we can simply create the fw_cfg file at that point. > This also makes it possible to assert if fw_cfg is not there > rather than skipping the device silently. > > Reviewed-by: Laszlo Ersek > Signed-off-by: Michael S. Tsirkin > --- > > Changes from v1: > don't assert if !fw_cfg, simply skip fwcfg > > hw/misc/pvpanic.c | 26 ++++++++++++++------------ > 1 file changed, 14 insertions(+), 12 deletions(-) Patches look good, however I think you missed to update the 1/2 commit message completely. You removed the sentence Others don't use fw_cfg at all. but This also makes it possible to assert if fw_cfg is not there rather than skipping the device silently. remains, although it's exactly the assert() that's been erased. Laszlo