From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpLWo-0007Kn-7Y for qemu-devel@nongnu.org; Wed, 19 Jun 2013 12:46:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpLWm-0001Df-SM for qemu-devel@nongnu.org; Wed, 19 Jun 2013 12:46:38 -0400 Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:57641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpLWm-0001CV-Mb for qemu-devel@nongnu.org; Wed, 19 Jun 2013 12:46:36 -0400 Received: by mail-wg0-f48.google.com with SMTP id f11so4650097wgh.3 for ; Wed, 19 Jun 2013 09:46:36 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51C1E065.801@redhat.com> Date: Wed, 19 Jun 2013 18:46:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1371576844-28743-1-git-send-email-mjt@msgid.tls.msk.ru> <20130619141622.GF31475@stefanha-thinkpad.muc.redhat.com> In-Reply-To: <20130619141622.GF31475@stefanha-thinkpad.muc.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 0/4] per-object libraries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Michael Tokarev , qemu-devel@nongnu.org Il 19/06/2013 16:16, Stefan Hajnoczi ha scritto: >> The foo.cflags isn't really necessary, but when you specify one >> > thing one way (target-specific variable), and another thing completely >> > different way, resulting code does not look nice. In particular, the >> > two curl definitions in block/Makefile.objs look somewhat funky if >> > curl.cflags isn't used. > Specifying per-object file or per-module LIBS/CFLAGS is great. I wonder > if we can do it like kbuild though: > CFLAGS_i915_trace_points.o := -I$(src) I think that works for kbuild because under the hood it is recursive makefile (using the trick that foo/bar/ does a recursive invocation). QEMU's makefile is non-recursive. Paolo