From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpkrQ-0004PE-Kx for qemu-devel@nongnu.org; Thu, 20 Jun 2013 15:49:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpkrP-0005lu-AE for qemu-devel@nongnu.org; Thu, 20 Jun 2013 15:49:36 -0400 Message-ID: <51C35CC9.7080105@redhat.com> Date: Thu, 20 Jun 2013 20:49:29 +0100 From: Eric Blake MIME-Version: 1.0 References: <1371674435-14973-1-git-send-email-aliguori@us.ibm.com> <1371674435-14973-2-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1371674435-14973-2-git-send-email-aliguori@us.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2OESFXLMABGXFCEQTCAGS" Subject: Re: [Qemu-devel] [PATCH 01/12] chardev: ringbuf: add optional save parameter to save state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Alexey Kardashevskiy , qemu-devel@nongnu.org, Alex Graf , Paul Mackerras , qemu-ppc@nongnu.org, Andreas Faerber This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2OESFXLMABGXFCEQTCAGS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/19/2013 09:40 PM, Anthony Liguori wrote: > It is very useful to use the ringbuf chardev for writing test > cases and even more useful if the state of the ringbuf is migrated > with the guest. Otherwise it's hard to detect data loss in a test > case. >=20 > Signed-off-by: Anthony Liguori > --- > qapi-schema.json | 3 ++- > qemu-char.c | 45 +++++++++++++++++++++++++++++++++++++++++++-- > 2 files changed, 45 insertions(+), 3 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index a80ee40..90602d1 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3280,10 +3280,11 @@ > # Configuration info for memory chardevs > # > # @size: #optional Ringbuffer size, must be power of two, default is 6= 5536 > +# @save: #optional Register a savevm handler, default false Useful to have a '(since 1.6)' notation on the added field. > # > # Since: 1.5 > ## > -{ 'type': 'ChardevMemory', 'data': { '*size' : 'int' } } > +{ 'type': 'ChardevMemory', 'data': { '*size' : 'int', '*save': 'bool'= } } Yet another case for introspection discovering an added feature to an existing command. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2OESFXLMABGXFCEQTCAGS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRw1zJAAoJEKeha0olJ0NqmQoH/jNmcpddrKz7jRys0NR6xg6L nZ+k+7CGOAOhobLsOh/K9BSBdb9g8r/z37TK+9+0PTcCWTQV4ldMOph3gG6ZrRg9 aI1g5oyN69wsvh0ymtkdOU2u38K7irEd+4GJnQBKSa1BCS+WaZHhvHcTNvGeovvg 9IV+sejZmB0NVhdQFVzDOaYESKW8Y4uPpjgRHOwVuWxBpidzvWkzyDvCPD0E7q9A CHLpDaYxb6IaxNXS8isIYXHfqX7pvLRb2XbZjipgHr4yMSpxwDg65HCOPDqp0F4b 8aj3DKxtzoEfbmV2W/3Fc6T8DR2V8Z+1efQvaItZikpXgwt7Uitxu6a5jUGPFDw= =ITg6 -----END PGP SIGNATURE----- ------enig2OESFXLMABGXFCEQTCAGS--