From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: "Hu Tao" <hutao@cn.fujitsu.com>,
"Andreas Färber" <afaerber@suse.de>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Object cast macro change-pattern automation.
Date: Fri, 21 Jun 2013 09:36:46 +0200 [thread overview]
Message-ID: <51C4028E.20301@redhat.com> (raw)
In-Reply-To: <CAEgOgz5CGekoYvEuTN1519tVxu1gPgGO11m8C25C3xK2hdBCfQ@mail.gmail.com>
Il 21/06/2013 06:21, Peter Crosthwaite ha scritto:
> diff --git a/hw/timer/xilinx_timer.c b/hw/timer/xilinx_timer.c
> index 0c39cff..ae09170 100644
> --- a/hw/timer/xilinx_timer.c
> +++ b/hw/timer/xilinx_timer.c
> @@ -218,7 +218,7 @@ static int xilinx_timer_init(SysBusDevice *dev)
> ptimer_set_freq(xt->ptimer, t->freq_hz);
> }
>
> - memory_region_init_io(&t->mmio, &timer_ops, t, "xlnx.xps-timer",
> + memory_region_init_io(&t->mmio, &timer_ops, t, TYPE_XILINX_TIMER,
> R_MAX * 4 * num_timers(t));
> sysbus_init_mmio(dev, &t->mmio);
> return 0;
> @@ -241,7 +241,7 @@ static void xilinx_timer_class_init(ObjectClass
Isn't this a false positive?
Paolo
next prev parent reply other threads:[~2013-06-21 7:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 4:21 [Qemu-devel] Object cast macro change-pattern automation Peter Crosthwaite
2013-06-21 7:36 ` Paolo Bonzini [this message]
2013-06-21 7:44 ` Peter Crosthwaite
2013-06-21 8:40 ` Andreas Färber
2013-06-21 12:24 ` Paolo Bonzini
2013-06-21 7:45 ` Hu Tao
2013-06-21 7:49 ` Hu Tao
2013-06-21 9:33 ` Andreas Färber
2013-06-21 10:38 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C4028E.20301@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=hutao@cn.fujitsu.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).