From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54528)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Upvtw-0008HT-O9
	for qemu-devel@nongnu.org; Fri, 21 Jun 2013 03:36:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Upvtv-0006WH-Eu
	for qemu-devel@nongnu.org; Fri, 21 Jun 2013 03:36:56 -0400
Received: from mail-ee0-x231.google.com ([2a00:1450:4013:c00::231]:54626)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Upvtv-0006W5-9L
	for qemu-devel@nongnu.org; Fri, 21 Jun 2013 03:36:55 -0400
Received: by mail-ee0-f49.google.com with SMTP id b57so4324042eek.8
	for <qemu-devel@nongnu.org>; Fri, 21 Jun 2013 00:36:54 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51C4028E.20301@redhat.com>
Date: Fri, 21 Jun 2013 09:36:46 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <CAEgOgz5CGekoYvEuTN1519tVxu1gPgGO11m8C25C3xK2hdBCfQ@mail.gmail.com>
In-Reply-To: <CAEgOgz5CGekoYvEuTN1519tVxu1gPgGO11m8C25C3xK2hdBCfQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Object cast macro change-pattern automation.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Hu Tao <hutao@cn.fujitsu.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

Il 21/06/2013 06:21, Peter Crosthwaite ha scritto:
> diff --git a/hw/timer/xilinx_timer.c b/hw/timer/xilinx_timer.c
> index 0c39cff..ae09170 100644
> --- a/hw/timer/xilinx_timer.c
> +++ b/hw/timer/xilinx_timer.c
> @@ -218,7 +218,7 @@ static int xilinx_timer_init(SysBusDevice *dev)
>          ptimer_set_freq(xt->ptimer, t->freq_hz);
>      }
> 
> -    memory_region_init_io(&t->mmio, &timer_ops, t, "xlnx.xps-timer",
> +    memory_region_init_io(&t->mmio, &timer_ops, t, TYPE_XILINX_TIMER,
>                            R_MAX * 4 * num_timers(t));
>      sysbus_init_mmio(dev, &t->mmio);
>      return 0;
> @@ -241,7 +241,7 @@ static void xilinx_timer_class_init(ObjectClass

Isn't this a false positive?

Paolo