From: Paolo Bonzini <pbonzini@redhat.com>
To: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Cc: stefanha@gmail.com, 1191606@bugs.launchpad.net,
lersek@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] iSCSI fix crash when using virtio and libiscsi
Date: Fri, 21 Jun 2013 09:38:18 +0200 [thread overview]
Message-ID: <51C402EA.1020903@redhat.com> (raw)
In-Reply-To: <1371781955-2745-1-git-send-email-ronniesahlberg@gmail.com>
Il 21/06/2013 04:32, Ronnie Sahlberg ha scritto:
> Stefan, List
>
> Please find a patch that fixes the crashes for using virtio with libiscsi.
> The problem was that block/iscsi.c always assumed we got a plain buffer to read data into, and when we got an iovector array instead we would overwrite pointers with garbage and crash.
>
> Since we can get iovectors for the write case as well I have added a fix for when the guest is writing data to the target to handle the iovector case as well.
>
>
> The new calls added are not protected with (LIBISCSI_FEATURE_IOVECTOR) checks
> since anyone building a new/current version of qemu should probably also build
> against a current libiscsi.
Not necessarily, you may build against an older libiscsi from the distro.
Can you resubmit with the checks intact?
Paolo
> I will send patches later to remove the current (LIBISCSI_FEATURE_IOVECTOR) checks in the rest of the file.
next prev parent reply other threads:[~2013-06-21 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 2:32 [Qemu-devel] [PATCH] iSCSI fix crash when using virtio and libiscsi Ronnie Sahlberg
2013-06-21 2:32 ` [Qemu-devel] [PATCH] Fix iSCSI crash on SG_IO with an iovector Ronnie Sahlberg
2013-06-21 7:38 ` Paolo Bonzini [this message]
2013-06-21 13:51 ` [Qemu-devel] [PATCH] iSCSI fix crash when using virtio and libiscsi ronnie sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C402EA.1020903@redhat.com \
--to=pbonzini@redhat.com \
--cc=1191606@bugs.launchpad.net \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).