From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Upxgn-0004hZ-TU for qemu-devel@nongnu.org; Fri, 21 Jun 2013 05:31:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Upxgm-0001Ew-Nt for qemu-devel@nongnu.org; Fri, 21 Jun 2013 05:31:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Upxgm-0001Ek-HA for qemu-devel@nongnu.org; Fri, 21 Jun 2013 05:31:28 -0400 Message-ID: <51C41D55.80006@redhat.com> Date: Fri, 21 Jun 2013 10:31:01 +0100 From: Eric Blake MIME-Version: 1.0 References: <1369917299-5725-1-git-send-email-stefanha@redhat.com> <1369917299-5725-11-git-send-email-stefanha@redhat.com> <51A74FFD.1020207@redhat.com> <20130603092130.GD16498@stefanha-thinkpad.redhat.com> <20130619112142.GJ2934@dhcp-200-207.str.redhat.com> In-Reply-To: <20130619112142.GJ2934@dhcp-200-207.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2DPJDQJKDIWBSDVPFUQLD" Subject: Re: [Qemu-devel] [PATCH v5 10/11] blockdev: add Abort transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Fam Zheng , qemu-devel@nongnu.org, xiawenc@linux.vnet.ibm.com, imain@redhat.com, Stefan Hajnoczi , Paolo Bonzini , dietmar@proxmox.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2DPJDQJKDIWBSDVPFUQLD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/19/2013 12:21 PM, Kevin Wolf wrote: > Am 03.06.2013 um 11:21 hat Stefan Hajnoczi geschrieben: >> On Thu, May 30, 2013 at 07:11:25AM -0600, Eric Blake wrote: >>> On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: >>>> The Abort action can be used to test QMP 'transaction' failure. Add= it >>>> as the last action to exercise the .abort() and .cleanup() code path= s >>>> for all previous actions. >>> >>> Another thread questioned whether we should name this action >>> __org.qemu-debug-abort, if only to be clear that it is not a normal >>> interface. >> >> kwolf: Do you want Abort to be namespaced as a debug-only action? >> >> I think it's perfectly supportable so there's no need to hide it. >> Granted it's rare that anyone would want to use this action. >=20 > I don't have a strong opinion on this. On the one hand it's probably > useless outside testing and debugging, on the other hand it won't be a > pain to support and the interface looks like it could be stable for > the next few years... >=20 > It's your patch, so you get to decide. I don't have a strong opinion, either - it doesn't matter what it is named if no one outside of qtest uses that name :) When developing libvirt interfaces around new actions, I might use an abort to intentionally test behavior of libvirt error-handling code, but that would still be something I do by hand (by any name) and not something coded into libvirt itself. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2DPJDQJKDIWBSDVPFUQLD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRxB1VAAoJEKeha0olJ0NqHBsIAIheDDemyBp98zaSBTVXxk5X ojTd7ag1YAMK/b3Cj9YvddihQ0Hhc7Bkb2dnn9D0MXAt0GLp2ZIuoYm6dApdvGx9 WdntSeK/NMrbKKjVBiRZAx4SswG7pYYxqKMEIZPdz9JhSpRONdmIGnVHammZOM0v SYp9BQn6psA7jSgDdCDE3vdTfGNP4ZIdjfw5sMFHxkZOGmPE4DlSCMDL0D5slKVn xqfBf/tcb+Dlscshv+pVJAVqDqJcXdcvPSR0u/4rpXoikMZS5acj4Q24a7X2ehCL t+AoSOwXY/ku8VrNL2+yFN+ouaU7dlbCAPAcBUQsaYTEZzGm9QZBmwB4snMl0TA= =k4H9 -----END PGP SIGNATURE----- ------enig2DPJDQJKDIWBSDVPFUQLD--